From: Vladimir Oltean <olteanv@gmail.com>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Russell King <linux@armlinux.org.uk>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Colin Foster <colin.foster@in-advantage.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
UNGLinuxDriver@microchip.com
Subject: Re: [PATCH net-next 2/2] net: mscc: ocelot: convert to phylink
Date: Sun, 15 Aug 2021 04:12:43 +0300 [thread overview]
Message-ID: <20210815011243.prsztuzllmgiflui@skbuf> (raw)
In-Reply-To: <20210815005622.1215653-3-vladimir.oltean@nxp.com>
On Sun, Aug 15, 2021 at 03:56:22AM +0300, Vladimir Oltean wrote:
> - switch (phydev->speed) {
> + if (duplex == DUPLEX_FULL)
> + mode |= DEV_MAC_MODE_CFG_FDX_ENA;
> + /* Only full duplex supported for now */
> + ocelot_port_writel(ocelot_port, DEV_MAC_MODE_CFG_FDX_ENA |
> + mode, DEV_MAC_MODE_CFG);
I forgot to add a change to the patch, we shouldn't unconditionally OR
with DEV_MAC_MODE_CFG_FDX_ENA like the old code did if we aren't in
DUPLEX_FULL mode.
Anyway I'll wait for the automatic build tests to finish and I'll resend
a v2 very quickly afterwards.
next prev parent reply other threads:[~2021-08-15 1:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-15 0:56 [PATCH net-next 0/2] Convert ocelot to phylink Vladimir Oltean
2021-08-15 0:56 ` [PATCH net-next 1/2] net: dsa: felix: stop calling ocelot_port_{enable,disable} Vladimir Oltean
2021-08-15 0:56 ` [PATCH net-next 2/2] net: mscc: ocelot: convert to phylink Vladimir Oltean
2021-08-15 1:12 ` Vladimir Oltean [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-18 18:10 [PATCH net-next 0/2] Convert Ocelot and Felix switches to PHYLINK Vladimir Oltean
2019-11-18 18:10 ` [PATCH net-next 2/2] net: mscc: ocelot: convert " Vladimir Oltean
2019-11-19 23:25 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815011243.prsztuzllmgiflui@skbuf \
--to=olteanv@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox