From: Jonathan Lemon <jonathan.lemon@gmail.com>
To: kuba@kernel.org, davem@davemloft.net, richardcochran@gmail.com
Cc: kernel-team@fb.com, netdev@vger.kernel.org
Subject: [PATCH net-next v2 1/4] ptp: ocp: Fix uninitialized variable warning spotted by clang.
Date: Mon, 16 Aug 2021 15:13:34 -0700 [thread overview]
Message-ID: <20210816221337.390645-2-jonathan.lemon@gmail.com> (raw)
In-Reply-To: <20210816221337.390645-1-jonathan.lemon@gmail.com>
If attempting to flash the firmware with a blob of size 0,
the entire write loop is skipped and the uninitialized err
is returned. Fix by setting to 0 first.
Fixes: 773bda964921 ("ptp: ocp: Expose various resources on the
timecard.")
Signed-off-by: Jonathan Lemon <jonathan.lemon@gmail.com>
---
drivers/ptp/ptp_ocp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index 92edf772feed..9e4317d1184f 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -763,7 +763,7 @@ ptp_ocp_devlink_flash(struct devlink *devlink, struct device *dev,
size_t off, len, resid, wrote;
struct erase_info erase;
size_t base, blksz;
- int err;
+ int err = 0;
off = 0;
base = bp->flash_start;
--
2.31.1
next prev parent reply other threads:[~2021-08-16 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 22:13 [PATCH net-next v2 0/4] ptp: ocp: minor updates and fixes Jonathan Lemon
2021-08-16 22:13 ` Jonathan Lemon [this message]
2021-08-16 22:13 ` [PATCH net-next v2 2/4] ptp: ocp: Fix error path for pci_ocp_device_init() Jonathan Lemon
2021-08-16 22:13 ` [PATCH net-next v2 3/4] ptp: ocp: Have Kconfig select NET_DEVLINK Jonathan Lemon
2021-08-16 22:13 ` [PATCH net-next v2 4/4] MAINTAINERS: Update for ptp_ocp driver Jonathan Lemon
2021-08-17 0:40 ` [PATCH net-next v2 0/4] ptp: ocp: minor updates and fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210816221337.390645-2-jonathan.lemon@gmail.com \
--to=jonathan.lemon@gmail.com \
--cc=davem@davemloft.net \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).