From: Stephen Hemminger <stephen@networkplumber.org>
To: Gokul Sivakumar <gokulkumar792@gmail.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2-next v2 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb"
Date: Tue, 17 Aug 2021 08:27:40 -0700 [thread overview]
Message-ID: <20210817082740.6be97031@hermes.local> (raw)
In-Reply-To: <20210814184727.2405108-3-gokulkumar792@gmail.com>
On Sun, 15 Aug 2021 00:17:26 +0530
Gokul Sivakumar <gokulkumar792@gmail.com> wrote:
> + if (!is_json_context())
> + print_string(PRINT_FP, NULL, "dev ", NULL);
Why not the check for is_json_context is unnecessary here.
That is what PRINT_FP does.
next prev parent reply other threads:[~2021-08-17 15:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-14 18:47 [PATCH iproute2-next v2 0/3] bridge: fixes regarding the colorized output Gokul Sivakumar
2021-08-14 18:47 ` [PATCH iproute2-next v2 1/3] bridge: reorder cmd line arg parsing to let "-c" detected as "color" option Gokul Sivakumar
2021-08-17 15:11 ` David Ahern
2021-08-17 17:17 ` Gokul Sivakumar
2021-08-14 18:47 ` [PATCH iproute2-next v2 2/3] bridge: fdb: don't colorize the "dev" & "dst" keywords in "bridge -c fdb" Gokul Sivakumar
2021-08-17 15:27 ` Stephen Hemminger [this message]
2021-08-17 17:22 ` Gokul Sivakumar
2021-08-14 18:47 ` [PATCH iproute2-next v2 3/3] man: bridge: fix the typo to change "-c[lor]" into "-c[olor]" in man page Gokul Sivakumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817082740.6be97031@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=gokulkumar792@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).