From: Vladimir Oltean <olteanv@gmail.com>
To: Aleksander Jan Bajkowski <olek2@wp.pl>
Cc: hauke@hauke-m.de, andrew@lunn.ch, vivien.didelot@gmail.com,
f.fainelli@gmail.com, davem@davemloft.net, kuba@kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: Re: [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay
Date: Tue, 17 Aug 2021 23:21:41 +0300 [thread overview]
Message-ID: <20210817202141.xddw5c7mypodnqlk@skbuf> (raw)
In-Reply-To: <20210817194448.tyg723667ql4kjvu@skbuf>
On Tue, Aug 17, 2021 at 10:44:48PM +0300, Vladimir Oltean wrote:
> On Tue, Aug 17, 2021 at 09:32:07PM +0200, Aleksander Jan Bajkowski wrote:
> > The delay is especially needed by the xRX300 and xRX330 SoCs. Without
> > this patch, some phys are sometimes not properly detected.
> >
> > Fixes: a09d042b086202735c4ed64 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > Tested-by: Aleksander Jan Bajkowski <olek2@wp.pl> # tested on DWR966, HH5A
> > ---
>
> Generally the convention is:
>
> From: Patch Author <patch.author@email.com>
>
> Commit description
>
> Signed-off-by: Patch Author <patch.author@email.com>
> Signed-off-by: Patch Carrier 1 <patch.carrier1@email.com>
> Signed-off-by: Patch Carrier 2 <patch.carrier2@email.com>
> Signed-off-by: Patch Carrier 3 <patch.carrier3@email.com>
> Signed-off-by: Patch Submitter <patch.submitter@email.com>
>
> This patch is clearly not following this model for more than one reason.
Let's not even talk about the kilometer-long commit sha1sum.
This is not even my pet peeve, if this patch gets merged as-is you'll
get an email titled "linux-next: Fixes tag needs some work in the net tree"
(google it if you want examples).
Stick this in your ~/.gitconfig and thank me later:
[core]
abbrev = 12
[pretty]
fixes = Fixes: %h (\"%s\")
Now run:
git show a09d042b086202735c4ed64 --pretty=fixes
Fixes: a09d042b0862 ("net: dsa: lantiq: allow to use all GPHYs on xRX300 and xRX330")
Voila!
prev parent reply other threads:[~2021-08-17 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 19:32 [PATCH] net: dsa: lantiq_gswip: Add 200ms assert delay Aleksander Jan Bajkowski
2021-08-17 19:44 ` Vladimir Oltean
2021-08-17 20:21 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817202141.xddw5c7mypodnqlk@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=netdev@vger.kernel.org \
--cc=olek2@wp.pl \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox