From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39896C4320A for ; Wed, 18 Aug 2021 14:19:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1580D610CB for ; Wed, 18 Aug 2021 14:19:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239399AbhHROU2 (ORCPT ); Wed, 18 Aug 2021 10:20:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:46447 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239932AbhHROTE (ORCPT ); Wed, 18 Aug 2021 10:19:04 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="216365836" X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="216365836" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Aug 2021 07:18:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,330,1620716400"; d="scan'208";a="511215988" Received: from ranger.igk.intel.com ([10.102.21.164]) by fmsmga004.fm.intel.com with ESMTP; 18 Aug 2021 07:18:24 -0700 Date: Wed, 18 Aug 2021 16:03:30 +0200 From: Maciej Fijalkowski To: "Nguyen, Anthony L" Cc: "intel-wired-lan@lists.osuosl.org" , "toke@redhat.com" , "Karlsson, Magnus" , "davem@davemloft.net" , "Lobakin, Alexandr" , "bjorn@kernel.org" , "Brandeburg, Jesse" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , "kuba@kernel.org" , "Creeley, Brett" , "joamaki@gmail.com" Subject: Re: [PATCH v5 intel-next 0/9] XDP_TX improvements for ice Message-ID: <20210818140330.GA25189@ranger.igk.intel.com> References: <20210814140812.46632-1-maciej.fijalkowski@intel.com> <86e7bcc04d8211fe5796bd7ecbea9458a725ad03.camel@intel.com> <20210818075256.GA16780@ranger.igk.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210818075256.GA16780@ranger.igk.intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 18, 2021 at 09:52:56AM +0200, Maciej Fijalkowski wrote: > On Tue, Aug 17, 2021 at 09:59:01PM +0100, Nguyen, Anthony L wrote: > > On Sat, 2021-08-14 at 16:08 +0200, Maciej Fijalkowski wrote: > > > With the v5, I think it's time for a proper change log. > > > > This isn't applying to the Intel-wired-LAN tree. If you want it to go > > through there, could you base the patches on that tree? > > Interestingly this is the first time that happens to me and I always based > my XDP related driver work on bpf-next. > > iwl tree is some standalone tree or is it just the net-next ? Turns out that you have the switchdev set in your branch and it's not on net-next yet. I have adjusted my set on top of that code and sent a v6. > > > > > Also, looking at NIPA, it looks like patches 2 and 3 have kdoc issues. > > Yeah I saw kdoc issue on patch 3 and wanted to ask you to fix this if you > would be applying that set but given that you're asking for a re-submit > i'll fix those by myself. > > > > > Thanks, > > Tony > > > > > v4->v5: > > > * fix issues pointed by lkp; variables used for updating ring stats > > > could be un-inited > > > * s/ice_ring/ice_rx_ring; it looks now symmetric given that we have > > > ice_tx_ring struct dedicated for Tx ring > > > * go through the code and use ice_for_each_* macros; it was spotted > > > by > > > Brett that there was a place around that code that this set is > > > touching that was not using the ice_for_each_txq. Turned out that > > > there > > > were more such places > > > * take care of coalesce related code; carry the info about type of > > > ring > > > container in ice_ring_container > > > * pull out getting rid of @ring_active onto separate patch, as > > > suggested > > > by Brett > > > > > > v3->v4: > > > * fix lkp issues; > > > > > > v2->v3: > > > * improve XDP_TX in a proper way > > > * split ice_ring > > > * propagate XDP ring pointer to Rx ring > > > > > > v1->v2: > > > * try to improve XDP_TX processing > > > > > > v4 : > > > https://lore.kernel.org/bpf/20210806095539.34423-1-maciej.fijalkowski@intel.com/ > > > v3 : > > > https://lore.kernel.org/bpf/20210805230046.28715-1-maciej.fijalkowski@intel.com/ > > > v2 : > > > https://lore.kernel.org/bpf/20210705164338.58313-1-maciej.fijalkowski@intel.com/ > > > v1 : > > > https://lore.kernel.org/bpf/20210601113236.42651-1-maciej.fijalkowski@intel.com/ > > > > > > Thanks! > > > Maciej > > > > > > Maciej Fijalkowski (9): > > > ice: remove ring_active from ice_ring > > > ice: move ice_container_type onto ice_ring_container > > > ice: split ice_ring onto Tx/Rx separate structs > > > ice: unify xdp_rings accesses > > > ice: do not create xdp_frame on XDP_TX > > > ice: propagate xdp_ring onto rx_ring > > > ice: optimize XDP_TX workloads > > > ice: introduce XDP_TX fallback path > > > ice: make use of ice_for_each_* macros > > > > > > drivers/net/ethernet/intel/ice/ice.h | 41 +++- > > > drivers/net/ethernet/intel/ice/ice_arfs.c | 2 +- > > > drivers/net/ethernet/intel/ice/ice_base.c | 51 ++--- > > > drivers/net/ethernet/intel/ice/ice_base.h | 8 +- > > > drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 9 +- > > > drivers/net/ethernet/intel/ice/ice_dcb_lib.h | 10 +- > > > drivers/net/ethernet/intel/ice/ice_ethtool.c | 93 +++++---- > > > drivers/net/ethernet/intel/ice/ice_lib.c | 88 +++++---- > > > drivers/net/ethernet/intel/ice/ice_lib.h | 6 +- > > > drivers/net/ethernet/intel/ice/ice_main.c | 142 +++++++++----- > > > drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +- > > > drivers/net/ethernet/intel/ice/ice_ptp.h | 4 +- > > > drivers/net/ethernet/intel/ice/ice_trace.h | 28 +-- > > > drivers/net/ethernet/intel/ice/ice_txrx.c | 183 +++++++++++----- > > > -- > > > drivers/net/ethernet/intel/ice/ice_txrx.h | 126 +++++++----- > > > drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 98 ++++++++-- > > > drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 14 +- > > > .../net/ethernet/intel/ice/ice_virtchnl_pf.c | 2 +- > > > drivers/net/ethernet/intel/ice/ice_xsk.c | 70 ++++--- > > > drivers/net/ethernet/intel/ice/ice_xsk.h | 20 +- > > > 20 files changed, 607 insertions(+), 390 deletions(-) > > >