From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A19C4320A for ; Tue, 24 Aug 2021 17:52:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2C8E61181 for ; Tue, 24 Aug 2021 17:51:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241647AbhHXRwm (ORCPT ); Tue, 24 Aug 2021 13:52:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241577AbhHXRwi (ORCPT ); Tue, 24 Aug 2021 13:52:38 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29DB0C05A52D; Tue, 24 Aug 2021 10:16:53 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id u3so45877026ejz.1; Tue, 24 Aug 2021 10:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZrICEbmTTI5X+hclm7WK+PbQzG8reRJWlDrlnWqe5QM=; b=V7GFYricmNupzBQJITddKiJ5ku1Lqevd9U9bxpSrk0jzLvBuYGDIYibumqRNN0x5vp pSb64XnQkxG4tDTrNORxvVC6r/yjy64p4Gcem3ESHcB5ZNYGrW9cl6YZfdTXqGRCiVe7 eq1VENoEhmH7DmNn4kapGxS5qi7KlF/N9RlD8Lx/C+kZGtyG1RHWVREmLQsDYZbq6lYK tpn2eyaAgXC2EaIIEnLDW7kcIpM7qUcG94JDw+jLRXbvxpbKffMn3jD8swoBhVDcj8Ww Ac9UtFbl535gK/3LeP2yd3dSnBDXYhh61E8eFOiNrBs561D7YgygGR4UvbDe91vcLyzB 8uUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZrICEbmTTI5X+hclm7WK+PbQzG8reRJWlDrlnWqe5QM=; b=UBrtYsbN74rxMoQy7S0jC1MQSQ8CDx38+JEJNkcyNn9xA8DUUKiZ3UAIIy2mpL5xq2 Azf6mUp7etVhNNwHS1UsID2GZ1OdH6jTEjXc0qZ+mu+z9PEe88B4FwG3d5GWnfSz3R/Y HO6bJEo7iVUSx6LdGYHCTv8V5mWpuHsiOY1gL6SMIgbrKZurpCHLXHADjgLlgS3fPDIx WvlaGpq5znY/BuRZ0xrG3l3DLe+/pox7/rcRn2Gwa4LDdIjLHjATvL/ZSLG5nmfN+ErJ s7STi19AKcxjEnAfs+ViNvkuD81MHDDloxvITRghrvjGRqmVu4AWn/AffBbLx0Ikw2dx k/Kw== X-Gm-Message-State: AOAM532P40Zmch2kUz4Bym2NGyMLg+Ml0MKA3PeGW2r+EpgAzGb9NPHx 0ZYzjepNuICGwTV4rUu+YYU= X-Google-Smtp-Source: ABdhPJwdGCzqk1Ny2qU9cmtS61qz1uXqMNjNnjfRHaaaWhcZMJ32Yp6OFCb0QywNgpvRbXpje3KbyQ== X-Received: by 2002:a17:906:401:: with SMTP id d1mr1200691eja.242.1629825411500; Tue, 24 Aug 2021 10:16:51 -0700 (PDT) Received: from skbuf ([188.25.144.60]) by smtp.gmail.com with ESMTPSA id v1sm9951266ejd.31.2021.08.24.10.16.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 10:16:51 -0700 (PDT) Date: Tue, 24 Aug 2021 20:16:49 +0300 From: Vladimir Oltean To: DENG Qingfang Cc: Sean Wang , Landen Chao , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Philipp Zabel , Russell King , "open list:MEDIATEK SWITCH DRIVER" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" , open list Subject: Re: [PATCH net-next] net: dsa: mt7530: manually set up VLAN ID 0 Message-ID: <20210824171649.ebcolsbsqczomiee@skbuf> References: <20210824165253.1691315-1-dqfext@gmail.com> <20210824165742.xvkb3ke7boryfoj4@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824165742.xvkb3ke7boryfoj4@skbuf> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 24, 2021 at 07:57:42PM +0300, Vladimir Oltean wrote: > > +static int > > +mt7530_setup_vlan0(struct mt7530_priv *priv) > > +{ > > + u32 val; > > + > > + /* Validate the entry with independent learning, keep the original > > + * ingress tag attribute. > > + */ > > + val = IVL_MAC | EG_CON | PORT_MEM(MT7530_ALL_MEMBERS) | FID(FID_BRIDGED) | > > FID_BRIDGED? yes, FID_BRIDGED. Please confirm that the Fixes: tag is the one you intend. The patch appears fine otherwise.