From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8D24C4320A for ; Wed, 25 Aug 2021 04:22:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A5496610FD for ; Wed, 25 Aug 2021 04:22:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230379AbhHYEXJ (ORCPT ); Wed, 25 Aug 2021 00:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229446AbhHYEXI (ORCPT ); Wed, 25 Aug 2021 00:23:08 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 35951C061757 for ; Tue, 24 Aug 2021 21:22:23 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIkQU-00040Z-Cl; Wed, 25 Aug 2021 06:22:10 +0200 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1mIkQR-0000tw-UG; Wed, 25 Aug 2021 06:22:07 +0200 Date: Wed, 25 Aug 2021 06:22:07 +0200 From: Oleksij Rempel To: kernel test robot Cc: kbuild-all@lists.01.org, Linux Memory Management List , Jakub Kicinski , Andrew Lunn , Colin Ian King , Grant Grundler , Heiner Kallweit , Oliver Neukum , linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: usb: asix: ax88772: fix boolconv.cocci warnings Message-ID: <20210825042207.GC14337@pengutronix.de> References: <202108250651.uuW5Q2Rg-lkp@intel.com> <20210824221716.GA23759@2b586af07b64> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210824221716.GA23759@2b586af07b64> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 06:08:53 up 188 days, 7:32, 79 users, load average: 0.06, 0.23, 0.30 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Aug 25, 2021 at 06:17:16AM +0800, kernel test robot wrote: > From: kernel test robot > > drivers/net/usb/asix_devices.c:757:60-65: WARNING: conversion to bool not needed here > > Remove unneeded conversion to bool > > Semantic patch information: > Relational and logical operators evaluate to bool, > explicit conversion is overly verbose and unneeded. > > Generated by: scripts/coccinelle/misc/boolconv.cocci > > Fixes: 7a141e64cf14 ("net: usb: asix: ax88772: move embedded PHY detection as early as possible") > CC: Oleksij Rempel > Reported-by: kernel test robot > Signed-off-by: kernel test robot Reviewed-by: Oleksij Rempel > --- > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 372b2891c15acbf7b90d948b08ac174bde77102c > commit: 7a141e64cf14099d84e530db0e86fcb2c489e341 [9154/10077] net: usb: asix: ax88772: move embedded PHY detection as early as possible > :::::: branch date: 12 hours ago > :::::: commit date: 35 hours ago > > asix_devices.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/usb/asix_devices.c > +++ b/drivers/net/usb/asix_devices.c > @@ -754,7 +754,7 @@ static int ax88772_bind(struct usbnet *d > return ret; > > priv->phy_addr = ret; > - priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10 ? true : false); > + priv->embd_phy = ((priv->phy_addr & 0x1f) == 0x10); > > asix_read_cmd(dev, AX_CMD_STATMNGSTS_REG, 0, 0, 1, &chipcode, 0); > chipcode &= AX_CHIPCODE_MASK; > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |