netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: roopa@nvidia.com, Joachim Wiberg <troglobit@gmail.com>,
	dsahern@gmail.com, Nikolay Aleksandrov <nikolay@nvidia.com>
Subject: [PATCH iproute2-next 08/17] bridge: vlan: add global mcast_last_member_count option
Date: Thu, 26 Aug 2021 16:05:24 +0300	[thread overview]
Message-ID: <20210826130533.149111-9-razor@blackwall.org> (raw)
In-Reply-To: <20210826130533.149111-1-razor@blackwall.org>

From: Nikolay Aleksandrov <nikolay@nvidia.com>

Add control and dump support for the global mcast_last_member_count option
which controls the number of queries the bridge will send on the vlan after
a leave is received (default 2).
Syntax:
 $ bridge vlan global set dev bridge vid 1 mcast_last_member_count 10

Signed-off-by: Nikolay Aleksandrov <nikolay@nvidia.com>
---
 bridge/vlan.c     | 15 +++++++++++++++
 man/man8/bridge.8 | 10 +++++++++-
 2 files changed, 24 insertions(+), 1 deletion(-)

diff --git a/bridge/vlan.c b/bridge/vlan.c
index 00b4f8a00d9b..ee9442e3908f 100644
--- a/bridge/vlan.c
+++ b/bridge/vlan.c
@@ -41,6 +41,7 @@ static void usage(void)
 		"       bridge vlan global { set } vid VLAN_ID dev DEV [ mcast_snooping MULTICAST_SNOOPING ]\n"
 		"                                                      [ mcast_igmp_version IGMP_VERSION ]\n"
 		"                                                      [ mcast_mld_version MLD_VERSION ]\n"
+		"                                                      [ mcast_last_member_count LAST_MEMBER_COUNT ]\n"
 		"       bridge vlan global { show } [ dev DEV ] [ vid VLAN_ID ]\n");
 	exit(-1);
 }
@@ -358,6 +359,7 @@ static int vlan_global_option_set(int argc, char **argv)
 	short vid_end = -1;
 	char *d = NULL;
 	short vid = -1;
+	__u32 val32;
 	__u8 val8;
 
 	afspec = addattr_nest(&req.n, sizeof(req),
@@ -419,6 +421,13 @@ static int vlan_global_option_set(int argc, char **argv)
 				invarg("invalid mcast_mld_version", *argv);
 			addattr8(&req.n, 1024,
 				 BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION, val8);
+		} else if (strcmp(*argv, "mcast_last_member_count") == 0) {
+			NEXT_ARG();
+			if (get_u32(&val32, *argv, 0))
+				invarg("invalid mcast_last_member_count", *argv);
+			addattr32(&req.n, 1024,
+				  BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT,
+				  val32);
 		} else {
 			if (matches(*argv, "help") == 0)
 				NEXT_ARG();
@@ -767,6 +776,12 @@ static void print_vlan_global_opts(struct rtattr *a, int ifindex)
 		print_uint(PRINT_ANY, "mcast_mld_version",
 			   "mcast_mld_version %u ", rta_getattr_u8(vattr));
 	}
+	if (vtb[BRIDGE_VLANDB_GOPTS_MCAST_MLD_VERSION]) {
+		vattr = vtb[BRIDGE_VLANDB_GOPTS_MCAST_LAST_MEMBER_CNT];
+		print_uint(PRINT_ANY, "mcast_last_member_count",
+			   "mcast_last_member_count %u ",
+			   rta_getattr_u32(vattr));
+	}
 	print_nl();
 	close_json_object();
 }
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index dcbff9367334..cea755184336 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -163,7 +163,9 @@ bridge \- show / manipulate bridge addresses and devices
 .B mcast_igmp_version
 .IR IGMP_VERSION " ] [ "
 .B mcast_mld_version
-.IR MLD_VERSION " ]"
+.IR MLD_VERSION " ] [ "
+.B mcast_last_member_count
+.IR LAST_MEMBER_COUNT " ]"
 
 .ti -8
 .BR "bridge vlan global" " [ " show " ] [ "
@@ -943,6 +945,12 @@ set the IGMP version. Default is 2.
 .BI mcast_mld_version " MLD_VERSION "
 set the MLD version. Default is 1.
 
+.TP
+.BI mcast_last_member_count " LAST_MEMBER_COUNT "
+set multicast last member count, ie the number of queries the bridge
+will send before stopping forwarding a multicast group after a "leave"
+message has been received. Default is 2.
+
 .SS bridge vlan global show - list global vlan options.
 
 This command displays the global VLAN options for each VLAN entry.
-- 
2.31.1


  parent reply	other threads:[~2021-08-26 13:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-26 13:05 [PATCH iproute2-next 00/17] bridge: vlan: add global multicast options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 01/17] ip: bridge: add support for mcast_vlan_snooping Nikolay Aleksandrov
2021-08-26 15:08   ` Stephen Hemminger
2021-08-26 15:11     ` Nikolay Aleksandrov
2021-08-27 17:01       ` David Ahern
2021-08-26 13:05 ` [PATCH iproute2-next 02/17] bridge: vlan: add support to show global vlan options Nikolay Aleksandrov
2021-08-27 17:10   ` David Ahern
2021-08-26 13:05 ` [PATCH iproute2-next 03/17] bridge: vlan: add support for vlan filtering when dumping options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 04/17] bridge: vlan: add support to set global vlan options Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 05/17] bridge: vlan: add global mcast_snooping option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 06/17] bridge: vlan: add global mcast_igmp_version option Nikolay Aleksandrov
2021-08-31  9:02   ` Joachim Wiberg
2021-08-31  9:04     ` Nikolay Aleksandrov
2021-08-31  9:10       ` Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 07/17] bridge: vlan: add global mcast_mld_version option Nikolay Aleksandrov
2021-08-26 13:05 ` Nikolay Aleksandrov [this message]
2021-08-26 13:05 ` [PATCH iproute2-next 09/17] bridge: vlan: add global mcast_startup_query_count option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 10/17] bridge: vlan: add global mcast_last_member_interval option Nikolay Aleksandrov
2021-08-27 17:15   ` David Ahern
     [not found]     ` <DM4PR12MB5278D58FD0768A3005F95804DFC89@DM4PR12MB5278.namprd12.prod.outlook.com>
2021-08-27 18:21       ` David Ahern
2021-08-26 13:05 ` [PATCH iproute2-next 11/17] bridge: vlan: add global mcast_membership_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 12/17] bridge: vlan: add global mcast_querier_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 13/17] bridge: vlan: add global mcast_query_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 14/17] bridge: vlan: add global mcast_query_response_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 15/17] bridge: vlan: add global mcast_startup_query_interval option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 16/17] bridge: vlan: add global mcast_querier option Nikolay Aleksandrov
2021-08-26 13:05 ` [PATCH iproute2-next 17/17] bridge: vlan: add support for dumping router ports Nikolay Aleksandrov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210826130533.149111-9-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=dsahern@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@nvidia.com \
    --cc=roopa@nvidia.com \
    --cc=troglobit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).