From: Kalle Valo <kvalo@codeaurora.org>
To: Kees Cook <keescook@chromium.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
Kees Cook <keescook@chromium.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Larry Finger <Larry.Finger@lwfinger.net>,
Colin Ian King <colin.king@canonical.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
Joe Perches <joe@perches.com>, Kaixu Xia <kaixuxia@tencent.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] rtlwifi: rtl8192de: Style clean-ups
Date: Sun, 29 Aug 2021 07:30:28 +0000 (UTC) [thread overview]
Message-ID: <20210829073028.69AECC43460@smtp.codeaurora.org> (raw)
In-Reply-To: <20210826023230.1148924-1-keescook@chromium.org>
Kees Cook <keescook@chromium.org> wrote:
> Clean up some style issues:
> - Use ARRAY_SIZE() for arrays (even when u8 sized)
> - Remove redundant CHANNEL_MAX_NUMBER_2G define.
> Additionally fix some dead code WARNs.
>
> Cc: Ping-Ke Shih <pkshih@realtek.com>
> Cc: Kalle Valo <kvalo@codeaurora.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Colin Ian King <colin.king@canonical.com>
> Cc: linux-wireless@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Failed to apply, please rebase over wireless-drivers-next.
error: sha1 information is lacking or useless (drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch' to see the failed patch
Applying: rtlwifi: rtl8192de: Style clean-ups
Patch failed at 0001 rtlwifi: rtl8192de: Style clean-ups
Patch set to Changes Requested.
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210826023230.1148924-1-keescook@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-08-29 7:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 2:32 [PATCH v2] rtlwifi: rtl8192de: Style clean-ups Kees Cook
2021-08-26 3:07 ` Pkshih
2021-08-29 7:30 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829073028.69AECC43460@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=joe@perches.com \
--cc=kaixuxia@tencent.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).