From: Kalle Valo <kvalo@codeaurora.org>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Arend van Spriel <aspriel@gmail.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-hsien Lin <chi-hsien.lin@infineon.com>,
Wright Feng <wright.feng@infineon.com>,
Chung-hsien Hsu <chung-hsien.hsu@infineon.com>,
kernel@pengutronix.de, Ahmad Fatoum <a.fatoum@pengutronix.de>,
SHA-cyfmac-dev-list@infineon.com,
brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org
Subject: Re: brcmfmac: pcie: fix oops on failure to resume and reprobe
Date: Sun, 29 Aug 2021 11:45:47 +0000 (UTC) [thread overview]
Message-ID: <20210829114547.76F0BC4361B@smtp.codeaurora.org> (raw)
In-Reply-To: <20210817063521.22450-1-a.fatoum@pengutronix.de>
Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> When resuming from suspend, brcmf_pcie_pm_leave_D3 will first attempt a
> hot resume and then fall back to removing the PCI device and then
> reprobing. If this probe fails, the kernel will oops, because brcmf_err,
> which is called to report the failure will dereference the stale bus
> pointer. Open code and use the default bus-less brcmf_err to avoid this.
>
> Fixes: 8602e62441ab ("brcmfmac: pass bus to the __brcmf_err() in pcie.c")
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
Patch applied to wireless-drivers-next.git, thanks.
d745ca4f2c4a brcmfmac: pcie: fix oops on failure to resume and reprobe
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210817063521.22450-1-a.fatoum@pengutronix.de/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-08-29 11:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 6:35 [PATCH] brcmfmac: pcie: fix oops on failure to resume and reprobe Ahmad Fatoum
2021-08-17 10:01 ` Ahmad Fatoum
[not found] ` <CAHp75Vfc_T04p95PgVUd+CK+ttPwX2aOC4WPD35Z01WQV1MxKw@mail.gmail.com>
2021-08-17 11:11 ` Ahmad Fatoum
2021-08-17 11:54 ` Andy Shevchenko
2021-08-17 12:03 ` Ahmad Fatoum
2021-08-17 12:07 ` Ahmad Fatoum
2021-08-17 13:06 ` Andy Shevchenko
2021-08-17 13:19 ` Ahmad Fatoum
2021-08-29 11:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829114547.76F0BC4361B@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=SHA-cyfmac-dev-list@infineon.com \
--cc=a.fatoum@pengutronix.de \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=chi-hsien.lin@infineon.com \
--cc=chung-hsien.hsu@infineon.com \
--cc=davem@davemloft.net \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).