From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5EAC432BE for ; Mon, 30 Aug 2021 07:33:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AAA960FC0 for ; Mon, 30 Aug 2021 07:33:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234152AbhH3HeV (ORCPT ); Mon, 30 Aug 2021 03:34:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36722 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232321AbhH3HeU (ORCPT ); Mon, 30 Aug 2021 03:34:20 -0400 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08CFAC061575 for ; Mon, 30 Aug 2021 00:33:27 -0700 (PDT) Received: by mail-wm1-x330.google.com with SMTP id i3so8113709wmq.3 for ; Mon, 30 Aug 2021 00:33:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=BclShfYYdOqAhYouAWe6+YvE1LNWpXyBg2GtzrhC0+s=; b=Tpzg0P0+7D5N4hEEyAIed3dAy/YSM9Ia8HdEhGELTEQlCvbTDzRm3NDJ89OhIlAjuQ u6SOW6qZk0iGpBUgMHzXOFaJmMQWuKTu7fXErmBL7z9oryxsqYv27NU1we66dI4F6CwO xpOA5BiEZNrE2dayYwfdL8C4l0TEeTuwTLiiWt1p7Ilx6RLi8fY5zg4HOpPi7lAPbPK/ nbs0b8fPzw8IhbSta2sG2hsLYBeq+IBw3qycONMQFmywsrMqJ+GQPe4Eh/DkwSpOKpYK wf/OOOS8EpDfrSnomfJSK5c3sy9jtiGiiK6WZj8ENoAlmvIi/ZmrFPslLvPBXbpRmn06 gg2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=BclShfYYdOqAhYouAWe6+YvE1LNWpXyBg2GtzrhC0+s=; b=OpZgc88Y/nYYppsDqjYrCMZSFkU85gjCWWM6j/k3q84Lg6qxCKj71SL8yQ5rMYePuW CGWV7bltNvbaUzyzpL2iD/zHOzW4zu+lzN8T0vjGj7aU5aNm614GJi2raAo5JXSOENXd ldlPahr/dY7sjdN/Gpsq7igLrsvRxsfomQ7Xcu2/2B3X6Q1848GnNSUraziwWUl3mSoE Wq5e/ZtgAbEQfWuHwBLpg1blTMXBtFVQxFyyLaYdI9dRvNk7PpzGmt2am9Hwe3u/48/h a88PuaE/+56UEH7iAeoOO3jcFQq9CcJNlclDA8svqSUyRnCs9SHVjZHEfWrLOFb3K4fX +zow== X-Gm-Message-State: AOAM531Vn0YeKugDXwNb/DoMjK96WH/GgcOFfLtVMMw+w3nhHHg0Fhn7 Y0NdIIDkMyDukRWo61Ub8Zg= X-Google-Smtp-Source: ABdhPJys+rthvFN859ClwWGSPgodpdecS/P5JEopc6t3hyE/Gd/BRsD7AbXO7zR6hqPN4M97WYUp4Q== X-Received: by 2002:a05:600c:3554:: with SMTP id i20mr9731118wmq.164.1630308805669; Mon, 30 Aug 2021 00:33:25 -0700 (PDT) Received: from skbuf ([82.78.148.104]) by smtp.gmail.com with ESMTPSA id o12sm13614035wmr.2.2021.08.30.00.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 00:33:25 -0700 (PDT) Date: Mon, 30 Aug 2021 10:33:24 +0300 From: Vladimir Oltean To: Linus Walleij Cc: Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, Alvin =?utf-8?Q?=C5=A0ipraga?= , Mauri Sandberg , DENG Qingfang Subject: Re: [PATCH net-next 2/2] net: dsa: rtl8366: Drop custom VLAN set-up Message-ID: <20210830073324.kye5lhgvsqb6exsn@skbuf> References: <20210829002601.282521-1-linus.walleij@linaro.org> <20210829002601.282521-2-linus.walleij@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210829002601.282521-2-linus.walleij@linaro.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Aug 29, 2021 at 02:26:01AM +0200, Linus Walleij wrote: > This hacky default VLAN setup was done in order to direct > packets to the right ports and provide port isolation, both > which we now support properly using custom tags and proper > bridge port isolation. > > We can drop the custom VLAN code and leave all VLAN handling > alone, as users expect things to be. We can also drop > ds->configure_vlan_while_not_filtering = false; and let > the core deal with any VLANs it wants. > > Cc: Vladimir Oltean > Cc: Alvin Šipraga > Cc: Mauri Sandberg > Cc: DENG Qingfang > Signed-off-by: Linus Walleij > --- Reviewed-by: Vladimir Oltean