Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

Ioana Ciornei
2021-08-16T14:47:57Z

On Tue, Jul 20, 2021 at 03:11:34PM +0100, Russell King (Oracle) wrote:
> On Tue, Jul 20, 2021 at 03:51:35PM +0200, Andrew Lunn wrote:
> > On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> > > Phylink documentation says:
> > > Note that the PHY may be able to transform from one connection
> > > technology to another, so, eg, don't clear 1000BaseX just
> > > because the MAC is unable to BaseX mode. This is more about
> > > clearing unsupported speeds and duplex settings. The port modes
> > > should not be cleared; phylink_set_port_modes() will help with this.
> > >
> > > So add the missing 10G modes.
> >
> > Hi Russell
> >
> > Would a phylink_set_10g(mask) helper make sense? As you say, it is
> > about the speed, not the individual modes.
>
> Yes, good point, and that will probably help avoid this in the future.
> We can't do that for things like e.g. SGMII though, because 1000/half
> isn't universally supported.
>
> Shall we get this patch merged anyway and then clean it up - as such
> a change will need to cover multiple drivers anyway?
>

This didn't get merged unfortunately.

Could you please resend it? Alternatively, I can take a look into adding
that phylink_set_10g() helper if that is what's keeping it from being
merged.

Ioana