Re: [PATCH net-next] net: dpaa2-mac: add support for more ethtool 10G link modes

Andrew Lunn
2021-07-20T13:56:04Z

On Tue, Jul 20, 2021 at 10:57:43AM +0100, Russell King wrote:
> Phylink documentation says:
> Note that the PHY may be able to transform from one connection
> technology to another, so, eg, don't clear 1000BaseX just
> because the MAC is unable to BaseX mode. This is more about
> clearing unsupported speeds and duplex settings. The port modes
> should not be cleared; phylink_set_port_modes() will help with this.
>
> So add the missing 10G modes.

Hi Russell

Would a phylink_set_10g(mask) helper make sense? As you say, it is
about the speed, not the individual modes.

Andrew