From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C32FFC433EF for ; Thu, 9 Sep 2021 11:44:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A70366135D for ; Thu, 9 Sep 2021 11:44:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238819AbhIILpS (ORCPT ); Thu, 9 Sep 2021 07:45:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:46894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239067AbhIILoB (ORCPT ); Thu, 9 Sep 2021 07:44:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B43EC6121F; Thu, 9 Sep 2021 11:42:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631187739; bh=XhIq0jyiZSNH1/9jtJS0FOQJIeZko4IRVlklc+AJ/bg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cOvna9bAEBHW6si2fk/sBCbeY4M2frHbmAvAKwy1lpKI1NmJw/qI9WMSKEUpyM6BV yTOwakuINGrlrpPfuHQQacYFMkPd3YUEGxyh4qiIebbOAlFx8F1cpm0qhohEDjTtIp qKQpBwVlx3Em2NtvzdNubdXFjrXPOKlNiLoGRYrQNIcF7RusKADLe5LDGJ15GoAfQv 8o6bz8Cssxg3+qqQOmozWDxH+mvKBXjJLvUxhKUlUHmu5llt7hUrOnp7d8GLJdqYeM j7vnSuhCQTCTB1K+TPY35UcWs2UhWdG15Dr7xrpVO9OdSO8/l0uL5U9cO2xCRBSNve 8Q8Otzev6LhRw== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: =?UTF-8?q?Niklas=20S=C3=B6derlund?= , Louis Peens , Simon Horman , "David S . Miller" , Sasha Levin , oss-drivers@corigine.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.14 057/252] nfp: fix return statement in nfp_net_parse_meta() Date: Thu, 9 Sep 2021 07:37:51 -0400 Message-Id: <20210909114106.141462-57-sashal@kernel.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210909114106.141462-1-sashal@kernel.org> References: <20210909114106.141462-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Niklas Söderlund [ Upstream commit 4431531c482a2c05126caaa9fcc5053a4a5c495b ] The return type of the function is bool and while NULL do evaluate to false it's not very nice, fix this by explicitly returning false. There is no functional change. Signed-off-by: Niklas Söderlund Signed-off-by: Louis Peens Signed-off-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 5dfa4799c34f..ed2ade2a4f04 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -1697,7 +1697,7 @@ nfp_net_parse_meta(struct net_device *netdev, struct nfp_meta_parsed *meta, case NFP_NET_META_RESYNC_INFO: if (nfp_net_tls_rx_resync_req(netdev, data, pkt, pkt_len)) - return NULL; + return false; data += sizeof(struct nfp_net_tls_resync_req); break; default: -- 2.30.2