From: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
To: netdev@vger.kernel.org
Cc: Brian King <brking@linux.ibm.com>,
cforno12@linux.ibm.com, Dany Madden <drt@linux.ibm.com>,
Rick Lindsley <ricklind@linux.ibm.com>,
Rick Lindsley <ricklind@linux.vnet.ibm.com>
Subject: [PATCH net-next RESEND v2 5/9] ibmvnic: init_tx_pools move loop-invariant code
Date: Tue, 14 Sep 2021 20:52:55 -0700 [thread overview]
Message-ID: <20210915035259.355092-6-sukadev@linux.ibm.com> (raw)
In-Reply-To: <20210915035259.355092-1-sukadev@linux.ibm.com>
In init_tx_pools() move some loop-invariant code out of the loop.
Reviewed-by: Rick Lindsley <ricklind@linux.vnet.ibm.com>
Reviewed-by: Dany Madden <drt@linux.ibm.com>
Signed-off-by: Sukadev Bhattiprolu <sukadev@linux.ibm.com>
---
drivers/net/ethernet/ibm/ibmvnic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 97041b319beb..bb9b8aec9c9b 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -843,11 +843,10 @@ static int init_tx_pools(struct net_device *netdev)
* allocation, release_tx_pools() will know how many to look for.
*/
adapter->num_active_tx_pools = num_pools;
+ buff_size = adapter->req_mtu + VLAN_HLEN;
+ buff_size = ALIGN(buff_size, L1_CACHE_BYTES);
for (i = 0; i < num_pools; i++) {
- buff_size = adapter->req_mtu + VLAN_HLEN;
- buff_size = ALIGN(buff_size, L1_CACHE_BYTES);
-
dev_dbg(dev, "Init tx pool %d [%llu, %llu]\n",
i, adapter->req_tx_entries_per_subcrq, buff_size);
--
2.26.2
next prev parent reply other threads:[~2021-09-15 3:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 3:52 [PATCH net-next RESEND v2 0/9] ibmvnic: Reuse ltb, rx, tx pools Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 1/9] ibmvnic: Consolidate code in replenish_rx_pool() Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 2/9] ibmvnic: Fix up some comments and messages Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 3/9] ibmvnic: Use/rename local vars in init_rx_pools Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 4/9] ibmvnic: Use/rename local vars in init_tx_pools Sukadev Bhattiprolu
2021-09-15 3:52 ` Sukadev Bhattiprolu [this message]
2021-09-15 3:52 ` [PATCH net-next RESEND v2 6/9] ibmvnic: Use bitmap for LTB map_ids Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 7/9] ibmvnic: Reuse LTB when possible Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 8/9] ibmvnic: Reuse rx pools " Sukadev Bhattiprolu
2021-09-15 3:52 ` [PATCH net-next RESEND v2 9/9] ibmvnic: Reuse tx " Sukadev Bhattiprolu
2021-09-15 10:30 ` [PATCH net-next RESEND v2 0/9] ibmvnic: Reuse ltb, rx, tx pools patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915035259.355092-6-sukadev@linux.ibm.com \
--to=sukadev@linux.ibm.com \
--cc=brking@linux.ibm.com \
--cc=cforno12@linux.ibm.com \
--cc=drt@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ricklind@linux.ibm.com \
--cc=ricklind@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).