From: DENG Qingfang <dqfext@gmail.com>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Rosen Penev <rosenp@gmail.com>
Subject: Re: [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy
Date: Wed, 15 Sep 2021 15:27:33 +0800 [thread overview]
Message-ID: <20210915072733.1494-1-dqfext@gmail.com> (raw)
In-Reply-To: <20210914123345.6321-1-ansuelsmth@gmail.com>
On Tue, Sep 14, 2021 at 02:33:45PM +0200, Ansuel Smith wrote:
> +}, {
> + /* QCA8327 */
> + .phy_id = QCA8327_PHY_ID,
> + .phy_id_mask = QCA8K_PHY_ID_MASK,
> + .name = "QCA PHY 8327",
> + /* PHY_GBIT_FEATURES */
> + .probe = at803x_probe,
> + .flags = PHY_IS_INTERNAL,
> + .config_init = qca83xx_config_init,
> + .soft_reset = genphy_soft_reset,
How about setting .suspend and .resume? Without these, the PHY cannot be
powered down/up administratively (via ip link set xxx down/up).
See commit 93100d6817b0.
Off-topic: When is .soft_reset called? The MediaTek PHY driver seems to work
fine without it.
> + .get_sset_count = at803x_get_sset_count,
> + .get_strings = at803x_get_strings,
> + .get_stats = at803x_get_stats,
> }, };
prev parent reply other threads:[~2021-09-15 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 12:33 [PATCH net-next v2] net: phy: at803x: add support for qca 8327 internal phy Ansuel Smith
2021-09-14 12:49 ` Andrew Lunn
2021-09-14 13:40 ` patchwork-bot+netdevbpf
2021-09-15 7:27 ` DENG Qingfang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210915072733.1494-1-dqfext@gmail.com \
--to=dqfext@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).