From: Stephen Hemminger <stephen@networkplumber.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Mirko Lindner <mlindner@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] sky2: Stop printing VPD info to debugfs
Date: Thu, 16 Sep 2021 15:13:59 -0700 [thread overview]
Message-ID: <20210916151359.7bf742df@hermes.local> (raw)
In-Reply-To: <bbaee8ab-9b2e-de04-ee7b-571e094cc5fe@gmail.com>
On Thu, 16 Sep 2021 23:40:37 +0200
Heiner Kallweit <hkallweit1@gmail.com> wrote:
> Sky2 is parsing the VPD and adds the parsed information to its debugfs
> file. This isn't needed in kernel, userspace tools like lspci can be
> used to display such information nicely. Therefore remove this from
> the driver.
>
> lspci -vv:
>
> Capabilities: [50] Vital Product Data
> Product Name: Marvell Yukon 88E8070 Gigabit Ethernet Controller
> Read-only fields:
> [PN] Part number: Yukon 88E8070
> [EC] Engineering changes: Rev. 1.0
> [MN] Manufacture ID: Marvell
> [SN] Serial number: AbCdEfG970FD4
> [CP] Extended capability: 01 10 cc 03
> [RV] Reserved: checksum good, 9 byte(s) reserved
> Read/write fields:
> [RW] Read-write area: 1 byte(s) free
> End
>
> Relevant part in debugfs file:
>
> 0000:01:00.0 Product Data
> Marvell Yukon 88E8070 Gigabit Ethernet Controller
> Part Number: Yukon 88E8070
> Engineering Level: Rev. 1.0
> Manufacturer: Marvell
> Serial Number: AbCdEfG970FD4
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Make sense lspci seems to have gotten better at handling this now.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
next prev parent reply other threads:[~2021-09-16 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 21:40 [PATCH net-next] sky2: Stop printing VPD info to debugfs Heiner Kallweit
2021-09-16 22:13 ` Stephen Hemminger [this message]
2021-09-18 1:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210916151359.7bf742df@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=mlindner@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).