From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEC5C433F5 for ; Fri, 17 Sep 2021 14:41:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8F4660F5B for ; Fri, 17 Sep 2021 14:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343819AbhIQOmk (ORCPT ); Fri, 17 Sep 2021 10:42:40 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52523 "EHLO out5-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343539AbhIQOmc (ORCPT ); Fri, 17 Sep 2021 10:42:32 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 80C265C01CF; Fri, 17 Sep 2021 10:41:10 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Fri, 17 Sep 2021 10:41:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=JJIeBqEx0vh8sMu7xDyH85/7PXTPW1rsvs7aQcd3Gy8=; b=ETb1kRqU Llyav/3S09cetcpR+NXnMbrwqABLR1rmacv6rataUQbjsBaR6r93vzQqXCksj6+9 rdbgQV5kiaBxpTiyVkDeHN7Me/4LyLBkfKRBiMyc1TQhB2zhh8/Nv8sPgeCL+3fG cRaJkvg+dCdGfBnM+imo/2G4Ng0yMGdwxZ9es09+PW+FTIc3C4m8M7bw5aldM5kr tyTNi9au7HI6GVAHuPvIwgjTrofpnwZ5kah18Mx7NsffsXYCTXrTGzXNlxKBJ94c BFj7ky41Jc1k7eJLP3diyU9m2idAo0P8PgBwG9LAQDZ5yVNX+fHZ9eW7FYKO73I0 yUYMXnzcjM41hw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehiedgjeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefhvffufffkofgjfhgggfestdekre dtredttdenucfhrhhomhepkfguohcuufgthhhimhhmvghluceoihguohhstghhsehiugho shgthhdrohhrgheqnecuggftrfgrthhtvghrnhepudetieevffffveelkeeljeffkefhke ehgfdtffethfelvdejgffghefgveejkefhnecuvehluhhsthgvrhfuihiivgepudenucfr rghrrghmpehmrghilhhfrhhomhepihguohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 17 Sep 2021 10:41:07 -0400 (EDT) From: Ido Schimmel To: netdev@vger.kernel.org Cc: mkubecek@suse.cz, vadimp@nvidia.com, moshe@nvidia.com, popadrian1996@gmail.com, mlxsw@nvidia.com, Ido Schimmel Subject: [PATCH ethtool-next 4/7] sff-8636: Remove incorrect comment Date: Fri, 17 Sep 2021 17:40:40 +0300 Message-Id: <20210917144043.566049-5-idosch@idosch.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210917144043.566049-1-idosch@idosch.org> References: <20210917144043.566049-1-idosch@idosch.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel The comment was copied from SFF-8472 (i.e., sfpdiag.c) where the diagnostic page is at I2C address 0x51. SFF-8636 only uses I2C address 0x50. Signed-off-by: Ido Schimmel --- qsfp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qsfp.c b/qsfp.c index e84226bc1554..263cf188377d 100644 --- a/qsfp.c +++ b/qsfp.c @@ -64,7 +64,7 @@ static struct sff8636_aw_flags { const char *str; /* Human-readable string, null at the end */ - int offset; /* A2-relative address offset */ + int offset; __u8 value; /* Alarm is on if (offset & value) != 0. */ } sff8636_aw_flags[] = { { "Laser bias current high alarm (Chan 1)", -- 2.31.1