From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CCC6C433EF for ; Mon, 20 Sep 2021 06:53:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD07561074 for ; Mon, 20 Sep 2021 06:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233311AbhITGzC (ORCPT ); Mon, 20 Sep 2021 02:55:02 -0400 Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:43688 "EHLO mx0a-00069f02.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229549AbhITGzB (ORCPT ); Mon, 20 Sep 2021 02:55:01 -0400 Received: from pps.filterd (m0246627.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18K4YZlo005954; Mon, 20 Sep 2021 06:53:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=z9ltXZ+gT8Dq5662Kq7p0QIDZXQ+LKwuKOFE0Xzs+bI=; b=q0nIV8+/nqsJOAyz+5YBl9ZYTgJ1YiNSdcE9xmoyu8MmqMa6R6QiEXAfrfr+SZnw557y DZnOavrvRg4yTYqkhV56N6cLwkYADm4iW4Nq3VF/xi3uvqqYuZIpnD6eTSJhMCfeslSj 8Cp2AxRiFd2wjeUBoGBLG724oS0LKfBOtSABCVsVcOObLw0dsWFNCTOvvb91YKssMvTJ jOrl6vhClfz+mGLmPxWbgpP9fUGudYQ9bvYnbQgiyu/Bh4oFHeaIlG6liSd6rR9MMyy9 VthpbGFkjI9h177acvYgBNZSoXIRDFPxcOUz3zzb+wSOZJKptcvUpKfs7cGVggcbeijq Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=z9ltXZ+gT8Dq5662Kq7p0QIDZXQ+LKwuKOFE0Xzs+bI=; b=an5HSbrnubrshxFK8BK1cqjI+DPJNK7ScOO51hXA4tIAFnLvk309Zqb93jkAYS8w9nD3 Ybj541AzzVOkfGLcxB+QufXmXVbYjvXEjmXeNjRef4xKV0oRfqLwZZlGGI7PX+at1gtC fIlyUc7X3GPv5HUQeKxtQXg2qcgBFUZxViUTMcwyMAvwTweez3aiuMEGfIAvU6hIk7pu zADHG8BbPcH43HoSkpNjOJyrPKVhznwXvdCPF6kTSFXvTEsKYwu1WPDR4M0Tvxbn1mMd SzsqF8WJ3QGLoCzNLfOub+KWT8Akl4mVAZrh/AY2uHSY9kLV3hYFyjeVdq2ICSogj0ow Sw== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by mx0b-00069f02.pphosted.com with ESMTP id 3b64269aqa-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Sep 2021 06:53:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18K6jr8Z019953; Mon, 20 Sep 2021 06:53:25 GMT Received: from nam12-bn8-obe.outbound.protection.outlook.com (mail-bn8nam12lp2175.outbound.protection.outlook.com [104.47.55.175]) by userp3020.oracle.com with ESMTP id 3b5svq949m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Sep 2021 06:53:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CbLJG72EZW2h4ID7swtlFRW+jxPZKYdqTgPEAVMI4rWsK5PCc7ZnH7V9jtLZwdhOIDOncg7cLnJKeB27PQWAFIE6CN0nJRhq0iJhqhz8kWhLosUvc3fnFeO8gFyre3Jm/7Ov8m6vulfWdwFZwDyuDU6jixWV6d2XeJAIWUDzNaz+g/Ptdq22nQ6UeMhTaJHy2YBpXT5cuTSBo2dbyBXXK5eEuZ8P04rdgczuHzjgXj9wDhZLsQOjY/wYl5uxhLU3zhDrTIC1qW5Pv4DHcJyYkUy2Pg1Jdn3sCkYsDIW5QcP6AgYkUSQLIUJ5kfeTrf0e166vR4QotPg4gCo71WZOHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z9ltXZ+gT8Dq5662Kq7p0QIDZXQ+LKwuKOFE0Xzs+bI=; b=dO/SpnjBgWMAN/TGHe2q3byPdNc8NszgnuJLlPXIpuVpBGy/zHZJKxLpsVzyTsM2gh9sjpihhfULwg798HH40+aFBoBTkDDjYtD7AmuOFCoo/1N5o4+3cMBh4lKvQy6gRZ6lXM1vQFi5hIyUKcRlxMXnE5s96b0jK8nsHGDc68lfUPhhK6o5Iw0CcxBjnidEnp+zDmVTuukUsgy8sLL8hXUUKMj66zJpXrglZ/A2/fMY1MPDU5KO76sCF0MbhFcvcLN+Zn5rZB/1I+zLp/QEciLnw8vzPlBINQ3VxuZi308i2+EpdM63anplL3bSVqzPqxTc+ydORZLn7ng3Ja3GlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=z9ltXZ+gT8Dq5662Kq7p0QIDZXQ+LKwuKOFE0Xzs+bI=; b=p1l7Px08/oUd+ayeu20z/8cha2euDvxtXrxIWbJCfgAzr4VV00dOj2fYAiunR1cg6XOzKIcrXFeOI+FB2yJYPjsuBNJfviOhv8eMcI1n2ZsVZaIDjE9ToCsriRpVDEyHOwvLI1pZtlK6qGcoDzkwdHEkHXVvOqUqO9dsBfN6xjE= Authentication-Results: linux.intel.com; dkim=none (message not signed) header.d=none;linux.intel.com; dmarc=none action=none header.from=oracle.com; Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by MWHPR1001MB2254.namprd10.prod.outlook.com (2603:10b6:301:2d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.18; Mon, 20 Sep 2021 06:53:22 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d409:11b5:5eb2:6be9]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::d409:11b5:5eb2:6be9%5]) with mapi id 15.20.4523.018; Mon, 20 Sep 2021 06:53:22 +0000 Date: Mon, 20 Sep 2021 09:53:02 +0300 From: Dan Carpenter To: M Chetan Kumar Cc: netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, johannes@sipsolutions.net, ryazanov.s.a@gmail.com, loic.poulain@linaro.org, krishna.c.sudi@intel.com, m.chetan.kumar@intel.com, linuxwwan@intel.com Subject: Re: [PATCH V2 net-next 1/6] net: wwan: iosm: devlink registration Message-ID: <20210920065301.GQ2116@kadam> References: <20210919172618.25992-1-m.chetan.kumar@linux.intel.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210919172618.25992-1-m.chetan.kumar@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: JNAP275CA0065.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::7) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 Received: from kadam (62.8.83.99) by JNAP275CA0065.ZAFP275.PROD.OUTLOOK.COM (2603:1086:0:4f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Mon, 20 Sep 2021 06:53:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7f71f9b7-72ac-4d17-a6c6-08d97c0355fc X-MS-TrafficTypeDiagnostic: MWHPR1001MB2254: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:126; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FvW1CrkqR6Qsik/ODvOQpE4kJBHra8EkBtnewRE3zGCnD7Loa+uFYgnG4ne8pTxJHUZ4eKDqcGFApPoyhq8hU4Z4x67MoUZA7J6MiUls5arqe3hNdtcO3Z7cbZI2d8ATqzBqSodlJVHA/1L4UveLvUyWjHtdg/jhIOyUJ3E60D5zRWYLNfLY6KUobB9UqsFRfk/bzJLaS3ITzMgHtGG6Wm1oQkOcbT/jiWZp7d7Cg+GCDHd+0XmfiXR7egZdr24Drey4UBDAIEOltXRugUlTakI2iPLDMyFB3MJcjHzlxpEyl5IBYg3UZJrORzpDiyv78taShKT8vBh54F+M8/ZulHFKJ9pdp1molfCzLq1BdotCol3U7Oxf6ySuwjIaLwYb5Pm+s4d54We3yOxTJG5LkinmajkDALjKlTvEbfYMLvbUECS5maivaNMrWdIXfG7s8s6gHDK7am7l2ipmE1kouc9tVC50ruDcvO/1OpCbkM+MyY39zztdpta/uzpBerdO7GObULJX7iPqSLKYTce9I5eVWbA43q4IOJe4TlvCf5Lel6c5hA4lNe8gqu4UjVVTaEjfGOC8X5SYoFPwUeczBcwj+xncpXJf0kihEGEglnfmqXSwM32c35V4/PjXsJCP/sl1e3kmzagUg4UJOq65QLgvlfRQ2TZl+lzndSSoW2bm5tJUMX6El6GTV5vDZTISa0NmeAtnzRmoqA/c5OaY9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1001MB2365.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(316002)(38100700002)(33716001)(7416002)(55016002)(33656002)(38350700002)(6496006)(26005)(6916009)(186003)(1076003)(86362001)(5660300002)(9686003)(8676002)(44832011)(956004)(52116002)(4326008)(66946007)(508600001)(83380400001)(66476007)(66556008)(6666004)(2906002)(8936002)(9576002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EJRGV/lcGdM65UZWoS+88MErcFoHZIFmv445cuY9ee7evGIl/VW8hkC2BNdK?= =?us-ascii?Q?jhg7FXWT2OQ5ORT5AzcukuI/MldosWMaXw1Ss+ucjCMzjm1uxwO2mNIRESvw?= =?us-ascii?Q?wMSs0L0orZWJDnrGmGkLDmH4d8+j78c4/KeU5h7K5//2mAzSrMWEs2ozntED?= =?us-ascii?Q?YxImH0+HwPSY7tuiBSY0d/pVx+AcbUOp8UB1A5Qk9SLZAIUkpT+7qpjGXeHN?= =?us-ascii?Q?oXNWhVlVGmUVJXn3PTDOnRYwWzWGcDUKVgnHN7XEzCIj2cYooSw9L76eFKCU?= =?us-ascii?Q?/GtHUECQSV2rMooiF1/uVT6kaK01NvB15wd/t1csq0fBHJsRAWRt17juhDxn?= =?us-ascii?Q?Zqg+6GT/6PpYSWEbhlY80+klNOk6p1WcAKkIAffkOHGBbBIg+Iheeo/unHZ4?= =?us-ascii?Q?VmJk2KQVhZsOQQ72rH9hG8JP+NxGKlRcuIRfxkxo11G3xkh9QeTxNZd2B8aM?= =?us-ascii?Q?MY2S9exy/HihwpkW6IPzuThHaYba9pVPXcL7IlpyyYldhwtSNtNK2BvGMC4E?= =?us-ascii?Q?4sa7qYBZKDfO7D3JLIr63mnlJVzhfr/onzfYL5aYyWdny+gDEJgIzt0VGyIJ?= =?us-ascii?Q?TdIDwgpQLxLxTZXWs6cTqR555JzhDoitBkPMWqN5GHmMLU0GaZPgDK7uwnj5?= =?us-ascii?Q?M+XBtOL24kjlrWwJfRbxxI7jl/fdhooA0b/4OElN9pNfFpxR6adVjAmdT8l7?= =?us-ascii?Q?vBk2jBYDOP56I6y4/oTaw7q2n673szfmU5mIGZ/PYRRenM8I0WajoEZymdIB?= =?us-ascii?Q?oR+gsonZbxYduBq5atZZqc47dFYzDGrI+tmRnt9r4lBKFH7VW5gugFmgflfG?= =?us-ascii?Q?XKr9o+n3m9k4BgjL5AMyris8PFZcnY0Y48NJs3QlS5cQ1rwU5DBUJ8CYl948?= =?us-ascii?Q?5OvOB/vXKfZa2lLx6FSouBVRJbnTRKTFaUd37lHz1Wgx+GJvwRRXDsAicOHb?= =?us-ascii?Q?msDL5pR84a4GWnqISHi8UXJtlmtV4rgUMCEeOy8FKq4u2sh4DSsNcC+fWeIN?= =?us-ascii?Q?Prn111bR8He182yN+HT6ozGV+pkSLT0TChDXpXYIcnkXmQprLigZcCFioFbZ?= =?us-ascii?Q?izQ6ch7pMQm7KGXVJ8/6PhxGOPOSoADEXx5MmDmmwaPEySydfk/vrkVRYxea?= =?us-ascii?Q?qN6c6njRrHzPW/wN+PBqPPf/tbnmGmFSfud5nu0kFJrh1jvP6SZC2nBNrv4H?= =?us-ascii?Q?ipUY+2ML3xQZBtLcaksavt5fdiIRInr/Dg8NK82InNWJyVbjfucbsJFOJ4IZ?= =?us-ascii?Q?eud1Lh63rsmwMGc/X635VYIWn9FAAEGJpkCetQahUt/bu6guvIPnMutCKB9L?= =?us-ascii?Q?4pGcOeCY/Aci4SSsqaaYRduQ?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7f71f9b7-72ac-4d17-a6c6-08d97c0355fc X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2021 06:53:22.2551 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KMXsmhTs1DcCpJhIleXgUyMjdQU4Q9kbf2B0hWcebX2qGJmvSR9r2/5tf97QNQ8Vp88qCPmRorjh+WKEhsmk6HXNInoqbytt08OV/wtESZE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1001MB2254 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10112 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109200039 X-Proofpoint-ORIG-GUID: GorjmRPyMcVND3RxdLsZCxA-WBWQDWXY X-Proofpoint-GUID: GorjmRPyMcVND3RxdLsZCxA-WBWQDWXY Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Small style nits. On Sun, Sep 19, 2021 at 10:56:18PM +0530, M Chetan Kumar wrote: > +static int ipc_devlink_flash_update(struct devlink *devlink, > + struct devlink_flash_update_params *params, > + struct netlink_ext_ack *extack) > +{ > + struct iosm_devlink *ipc_devlink = devlink_priv(devlink); > + enum iosm_flash_comp_type fls_type; > + u32 rc = -EINVAL; This should be an int. > + u8 *mdm_rsp; > + > + if (!params->component) > + return rc; It's more readable to return literals. "return -EINVAL;" > + > + mdm_rsp = kzalloc(IOSM_EBL_DW_PACK_SIZE, GFP_KERNEL); > + if (!mdm_rsp) > + return -ENOMEM; > + > + fls_type = ipc_devlink_get_flash_comp_type(params->component, > + strlen(params->component)); > + > + switch (fls_type) { > + case FLASH_COMP_TYPE_PSI: > + rc = ipc_flash_boot_psi(ipc_devlink, params->fw); > + break; > + case FLASH_COMP_TYPE_EBL: > + rc = ipc_flash_boot_ebl(ipc_devlink, params->fw); > + if (!rc) Always do error handling. Never do success handling. If you do: if (rc) break; > + rc = ipc_flash_boot_set_capabilities(ipc_devlink, > + mdm_rsp); Then this fits on one line. rc = ipc_flash_boot_set_capabilities(ipc_devlink, mdm_rsp); > + if (!rc) > + rc = ipc_flash_read_swid(ipc_devlink, mdm_rsp); > + break; > + case FLASH_COMP_TYPE_FLS: > + rc = ipc_flash_send_fls(ipc_devlink, params->fw, mdm_rsp); > + break; > + default: > + devlink_flash_update_status_notify(devlink, "Invalid component", > + params->component, 0, 0); > + break; > + } > + > + if (!rc) > + devlink_flash_update_status_notify(devlink, "Flashing success", > + params->component, 0, 0); > + else > + devlink_flash_update_status_notify(devlink, "Flashing failed", > + params->component, 0, 0); > + > + kfree(mdm_rsp); > + return rc; > +} [ snip ] > +static int ipc_devlink_coredump_snapshot(struct devlink *dl, > + const struct devlink_region_ops *ops, > + struct netlink_ext_ack *extack, > + u8 **data) > +{ > + struct iosm_devlink *ipc_devlink = devlink_priv(dl); > + struct iosm_coredump_file_info *cd_list = ops->priv; > + u32 region_size; > + int rc; > + > + dev_dbg(ipc_devlink->dev, "Region:%s, ID:%d", ops->name, > + cd_list->entry); > + region_size = cd_list->default_size; > + rc = ipc_coredump_collect(ipc_devlink, data, cd_list->entry, > + region_size); > + if (rc) { > + dev_err(ipc_devlink->dev, "Fail to create snapshot,err %d", rc); > + goto coredump_collect_err; > + } > + > + /* Send coredump end cmd indicating end of coredump collection */ > + if (cd_list->entry == (IOSM_NOF_CD_REGION - 1)) > + ipc_coredump_get_list(ipc_devlink, rpsi_cmd_coredump_end); > + > + return rc; Return literals if possible. return 0; Put a blank line after the "return 0;" > +coredump_collect_err: > + ipc_coredump_get_list(ipc_devlink, rpsi_cmd_coredump_end); > + return rc; > +} [ snip ] > +/** > + * struct iosm_rpsi_cmd - Structure for RPSI Command > + * @param: Used to calculate CRC > + * @cmd: Stores the RPSI command > + * @crc: Stores the CRC value > + */ > +struct iosm_rpsi_cmd { > + union iosm_rpsi_param_u param; > + __le16 cmd; > + __le16 crc; > +}; > + > +/** > + * ipc_devlink_init - To initialize the devlink to IOSM driver > + * @ipc_imem: Pointer to struct iosm_imem > + * > + * Returns: Pointer to iosm_devlink on success and NULL on failure > + */ These function comments should go in the .c file instead of the .h file. > +struct iosm_devlink *ipc_devlink_init(struct iosm_imem *ipc_imem); > + > +/** > + * ipc_devlink_deinit - To unintialize the devlink from IOSM driver. > + * @ipc_devlink: Devlink instance > + */ Same. > +void ipc_devlink_deinit(struct iosm_devlink *ipc_devlink); > + > +/** > + * ipc_devlink_send_cmd - Send command to Modem > + * @ipc_devlink: Pointer to struct iosm_devlink > + * @cmd: Command to be sent to modem > + * @entry: Command entry number > + * > + * Returns: 0 on success and failure value on error > + */ Same. > +int ipc_devlink_send_cmd(struct iosm_devlink *ipc_devlink, u16 cmd, u32 entry); > + > +#endif /* _IOSM_IPC_DEVLINK_H */ regards, dan carpenter