From: Steven Rostedt <rostedt@goodmis.org>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Zhongya Yan <yan2228598786@gmail.com>,
Eric Dumazet <edumazet@google.com>,
Brendan Gregg <brendan.d.gregg@gmail.com>,
Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Ingo Molnar <mingo@redhat.com>,
David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>, Yonghong Song <yhs@fb.com>,
Zhongya Yan <2228598786@qq.com>
Subject: Re: [PATCH] tcp: tcp_drop adds `SNMP` and `reason` parameter for tracing
Date: Mon, 20 Sep 2021 13:24:40 -0400 [thread overview]
Message-ID: <20210920132440.7a2febce@oasis.local.home> (raw)
In-Reply-To: <CAM_iQpVVbwN+uzxPbJabvju0CzxcFUosy0_xN=X9anA+wtiUVQ@mail.gmail.com>
On Mon, 20 Sep 2021 10:20:33 -0700
Cong Wang <xiyou.wangcong@gmail.com> wrote:
> > The strings were requested by the networking maintainers.
> >
> > https://lore.kernel.org/all/CANn89iJO8jzjFWvJ610TPmKDE8WKi8ojTr_HWXLz5g=4pdQHEA@mail.gmail.com/
>
> I think you misunderstand my point. Eric's point is hex address
> vs. string, which I never disagree. With SNMP enum, user-space
> can easily interpret it to string too, so at the end you still get strings
> but not from kernel. This would at least save a handful of strings
> from vmlinux, especially if we expand it beyond TCP.
If an enum is saved in the ring buffer, it is also trivial to have it
show a string in the buffer, as there's a way to map enums to strings
on output as well. Which I discussed in that same thread.
-- Steve
next prev parent reply other threads:[~2021-09-20 18:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 14:35 [PATCH] tcp: tcp_drop adds `SNMP` and `reason` parameter for tracing Zhongya Yan
2021-09-20 16:54 ` Cong Wang
2021-09-20 17:15 ` Steven Rostedt
2021-09-20 17:20 ` Cong Wang
2021-09-20 17:24 ` Steven Rostedt [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 5:31 Zhongya Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920132440.7a2febce@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=2228598786@qq.com \
--cc=brendan.d.gregg@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
--cc=yan2228598786@gmail.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).