netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ansuel Smith <ansuelsmth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Ansuel Smith <ansuelsmth@gmail.com>
Subject: [net-next PATCH 0/1] Sgmii fix for qca8k qca8327 switch
Date: Mon, 20 Sep 2021 18:47:44 +0200	[thread overview]
Message-ID: <20210920164745.30162-1-ansuelsmth@gmail.com> (raw)

Some background for this. As stated in other patch, we are testing
qca8327 switch in various device. We tought this was a specific
configuration of the switch and needed special binding to disable pll on
sgmii port. With a better analysis of the original qca driver it was
discovered that pll was only enabled on switch revision 1.

By testing the same configuration with a qca8337 switch that have a
revision 2, using the secondary cpu port (set as sgmii) as primary
(removed the first cpu port from dts and updated the driver to use the
secondary cpu port port6 for everything) confirmed that pll enabled is
not actually needed and all works correctly.
Different case for another router with a qca8327 switch that with the
extra option enabled doesn't work at all and no traffic can be detected.

Also in the original driver the signal detection (SD bit 4) is never
enabled. Having that enabled doesn't seems to give any problem so i
won't disable that, but i'm just pointing this out to think about it.

Don't know if that should be disabled or not but the pll changes is
absolutely needed as in some case it cause the malfunction of the entire
connection.

Ansuel Smith (1):
  drivers: net: dsa: qca8k: fix sgmii with some specific switch revision

 drivers/net/dsa/qca8k.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

-- 
2.32.0


             reply	other threads:[~2021-09-20 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 16:47 Ansuel Smith [this message]
2021-09-20 16:47 ` [net-next PATCH 1/1] drivers: net: dsa: qca8k: fix sgmii with some specific switch revision Ansuel Smith
2021-09-21 15:02   ` Andrey Jr. Melnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920164745.30162-1-ansuelsmth@gmail.com \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).