From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3592C433EF for ; Tue, 21 Sep 2021 15:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A419611C6 for ; Tue, 21 Sep 2021 15:03:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233846AbhIUPEy (ORCPT ); Tue, 21 Sep 2021 11:04:54 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:44638 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233809AbhIUPEw (ORCPT ); Tue, 21 Sep 2021 11:04:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632236603; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=bsSyjO77usODxPNl9U4WuLitIVjcU7QWauyIkVpnW1I=; b=HwqzLQwpVJVaX9d5w73r8xYPTjZRk4kyo3Rjyv4KrwgY/GUIh7thSuZ8lj9Nfi2Xn0yOa3mS 0lmoX/RXKPcDcSHn58PLH15R63uwCVYbJmw6REN/qROmeXZBXj54nwIzdavKVCtKLs8WAAl9 dhz4G6DC9FfhpLw4pq0PguA87Lk= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n01.prod.us-east-1.postgun.com with SMTP id 6149f41fbd6681d8edec436f (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 21 Sep 2021 15:02:55 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E59F6C4361B; Tue, 21 Sep 2021 15:02:54 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8888AC4338F; Tue, 21 Sep 2021 15:02:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 8888AC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH 1/9] mwifiex: Small cleanup for handling virtual interface type changes From: Kalle Valo In-Reply-To: <20210914195909.36035-2-verdre@v0yd.nl> References: <20210914195909.36035-2-verdre@v0yd.nl> To: =?utf-8?q?Jonas_Dre=C3=9Fler?= Cc: Amitkumar Karwar , Ganapathi Bhat , Sharvari Harisangam , Xinming Hu , "David S. Miller" , Jakub Kicinski , =?utf-8?q?Jonas_Dre=C3=9Fler?= , Tsuchiya Yuto , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Maximilian Luz , Andy Shevchenko , =?utf-8?q?Pali_Roh?= =?utf-8?q?=C3=A1r?= User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20210921150254.E59F6C4361B@smtp.codeaurora.org> Date: Tue, 21 Sep 2021 15:02:54 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Jonas Dreßler wrote: > Handle the obvious invalid virtual interface type changes with a general > check instead of looking at the individual change. > > For type changes from P2P_CLIENT to P2P_GO and the other way round, this > changes the behavior slightly: We now still do nothing, but return > -EOPNOTSUPP instead of 0. Now that behavior was incorrect before and > still is, because type changes between these two types are actually > possible and supported, which we'll fix in a following commit. > > Signed-off-by: Jonas Dreßler 9 patches applied to wireless-drivers-next.git, thanks. babe2a332dc4 mwifiex: Small cleanup for handling virtual interface type changes abe3a2c9ead8 mwifiex: Use function to check whether interface type change is allowed c2e9666cdffd mwifiex: Run SET_BSS_MODE when changing from P2P to STATION vif-type 54350dac4e6a mwifiex: Use helper function for counting interface types fae2aac8c740 mwifiex: Update virtual interface counters right after setting bss_type 25bbec30a2c7 mwifiex: Allow switching interface type from P2P_CLIENT to P2P_GO 5e2e1a4bf4a1 mwifiex: Handle interface type changes from AP to STATION c606008b7062 mwifiex: Properly initialize private structure on interface type changes 72e717500f99 mwifiex: Fix copy-paste mistake when creating virtual interface -- https://patchwork.kernel.org/project/linux-wireless/patch/20210914195909.36035-2-verdre@v0yd.nl/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches