From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238E8C433F5 for ; Tue, 21 Sep 2021 16:32:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BB3F6115A for ; Tue, 21 Sep 2021 16:32:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbhIUQdf (ORCPT ); Tue, 21 Sep 2021 12:33:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:42133 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbhIUQde (ORCPT ); Tue, 21 Sep 2021 12:33:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632241925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4FzVI0NgAL+4GbDA10ag57a7YP2ulK19sMtingEyh9g=; b=Nm+58HzWrrRMyaQJSAwlJpxBhF77xOUHLzaH7Citw9kiF/6fv9bCR/jOOomJlWYrymDa+g e492q5u9w5YCi4XUmkUzer/Lu3rkFmH+5RzyIk9jViuTOaNJMX10l2qd+amw6ajiXhkzhN yU+S8fiRWlAMGfq56b1wWNNFxKl9R28= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-470-DStJG2FmOzm3kPvqT-wuMg-1; Tue, 21 Sep 2021 12:32:04 -0400 X-MC-Unique: DStJG2FmOzm3kPvqT-wuMg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CED9A9126F; Tue, 21 Sep 2021 16:32:02 +0000 (UTC) Received: from localhost (unknown [10.40.194.136]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4C16A6D985; Tue, 21 Sep 2021 16:32:01 +0000 (UTC) Date: Tue, 21 Sep 2021 18:31:59 +0200 From: Jiri Benc To: David Ahern Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , William Tu , netdev@vger.kernel.org Subject: Re: [PATCH bpf-next] seltests: bpf: test_tunnel: use ip neigh Message-ID: <20210921183159.596a2662@redhat.com> In-Reply-To: <2f9554d2-c9c7-5c37-7df0-d011d80d7460@gmail.com> References: <40f24b9d3f0f53b5c44471b452f9a11f4d13b7af.1632236133.git.jbenc@redhat.com> <2f9554d2-c9c7-5c37-7df0-d011d80d7460@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 21 Sep 2021 09:23:06 -0600, David Ahern wrote: > I realize you are just following suit with this change, but ip can > change namespaces internally: > > ip -netns at_ns0 neigh add 10.1.1.200 lladdr 52:54:00:d9:02:00 dev $DEV_NS > > All of the 'ip netns exec ... ip ...' commands can be simplified. I know and I don't like the superfluous exec, either. But that's something for a different patch. As you said, I'm just following what's already there. There's ton of different stuff that can be cleaned up in this and other selftests, unfortunately. Jiri