From: Simon Horman <horms@kernel.org>
To: Ulrich Hecht <uli@fpond.eu>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
kuba@kernel.org, linux-can@vger.kernel.org,
netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Ayumi Nakamichi <ayumi.nakamichi.kf@renesas.com>
Subject: Re: [PATCH] can: rcar_can: Fix suspend/resume
Date: Wed, 22 Sep 2021 17:23:36 +0200 [thread overview]
Message-ID: <20210922152336.GA26223@kernel.org> (raw)
In-Reply-To: <1020394138.1395460.1632220693209@webmail.strato.com>
On Tue, Sep 21, 2021 at 12:38:13PM +0200, Ulrich Hecht wrote:
>
> > On 09/21/2021 7:19 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote:
> >
> >
> > If the driver was not opened, rcar_can_suspend() should not call
> > clk_disable() because the clock was not enabled.
> >
> > Fixes: fd1159318e55 ("can: add Renesas R-Car CAN driver")
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> > Tested-by: Ayumi Nakamichi <ayumi.nakamichi.kf@renesas.com>
> > ---
> > drivers/net/can/rcar/rcar_can.c | 21 +++++++++++++--------
> > 1 file changed, 13 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/net/can/rcar/rcar_can.c b/drivers/net/can/rcar/rcar_can.c
> > index 00e4533c8bdd..6b4eefb03044 100644
> > --- a/drivers/net/can/rcar/rcar_can.c
> > +++ b/drivers/net/can/rcar/rcar_can.c
...
> > @@ -858,6 +860,7 @@ static int __maybe_unused rcar_can_suspend(struct device *dev)
> > priv->can.state = CAN_STATE_SLEEPING;
> >
> > clk_disable(priv->clk);
> > +
> > return 0;
> > }
> >
nit: this hunk seems unrelated to the rest of the patch
...
next prev parent reply other threads:[~2021-09-22 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 5:19 [PATCH] can: rcar_can: Fix suspend/resume Yoshihiro Shimoda
2021-09-21 10:38 ` Ulrich Hecht
2021-09-22 15:23 ` Simon Horman [this message]
2021-09-24 7:43 ` Yoshihiro Shimoda
2021-09-23 13:30 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922152336.GA26223@kernel.org \
--to=horms@kernel.org \
--cc=ayumi.nakamichi.kf@renesas.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=uli@fpond.eu \
--cc=wg@grandegger.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).