From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DE61C433F5 for ; Thu, 23 Sep 2021 22:12:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7CFBB610FD for ; Thu, 23 Sep 2021 22:12:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236039AbhIWWNg (ORCPT ); Thu, 23 Sep 2021 18:13:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232145AbhIWWNf (ORCPT ); Thu, 23 Sep 2021 18:13:35 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 711A5C061574 for ; Thu, 23 Sep 2021 15:12:03 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id g8so28457890edt.7 for ; Thu, 23 Sep 2021 15:12:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=7tIIlep2yoDdtzPr18hxaRs7YF9bAFi1nuVBH57oNMw=; b=JOJ2xIAeuv1q1UemZ6tvzISM/Nj/1FbxRtbwAt2qZGPNzmY9+Y4I5OVQzu0bNB4BWm XoQjEhIdeJ40m2JA8bKnUofRmWwaSH70dYBZeZI/4J4X1lqUxPxEJium9ZSpKTZAUY11 SgDuD94abCw/c+zk7Iiye+VbN6dHaxE9x/qjnpChpzm0yoKu8S29DRN9qIZIsRurGRzA mEMYiU/A0mjDUyzaRhxOcujcEeMgJjDOBIetCN9248qCUsn3UAAMBfDjL4bmJ9vWfWxO P48RKOff3tUicT0TIP4CH8ZICexCC1MiKXB6nxUsxdIwExt8jzJJ7b22Yt8kJVTL+X6g XBIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7tIIlep2yoDdtzPr18hxaRs7YF9bAFi1nuVBH57oNMw=; b=45xh6+FRuSpB3U0x+CXJJ4mzloYzBwhASNMvwoqFeyoTqZZ6mXLoVbjk/jqfULmlQm 70+zQwRGdMMulF7LIKML0hQ3mz/kgw1WVkYl8XjU9/6LZoIV1KDW3e81N40DWP0+iyHG WGi949hxm8Ni655wSsei4cXyWZlDCc7mobb4kB//oHybE9XeICQVDpMZtJuBL+FcIBn0 /JXhZ19ZyhVRiE+fHPSbmxMrSP5eh/Kc55TCQs3ycTDm6jH+cyAcRgrbwO9JEOVuXCEa BV0/c6XQPdwTxlIk36kdXBiZnzBpTletGNXboVhKUn6W3mg9ApKeKi9KpKOIvHizMpXh QaRA== X-Gm-Message-State: AOAM530QgfNyQZQc46BgNIkjCh8Cz3+xUP+hJpgA+AZ4qU1cCq3udjOr 3AhZaBXYpLNUQPXhpEGttpQJaAQ1e/4= X-Google-Smtp-Source: ABdhPJyG0SavczT9zZXrvh4Qeyb5glIVcHWu9w9vdZPTZ8/1J5Qrph1Tr5sSFfnNnvVwo+9MXUW+4w== X-Received: by 2002:a05:6402:16d9:: with SMTP id r25mr1479895edx.80.1632435121929; Thu, 23 Sep 2021 15:12:01 -0700 (PDT) Received: from skbuf ([188.26.53.217]) by smtp.gmail.com with ESMTPSA id s4sm3808882eja.23.2021.09.23.15.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Sep 2021 15:12:01 -0700 (PDT) Date: Fri, 24 Sep 2021 01:12:00 +0300 From: Vladimir Oltean To: Linus Walleij Cc: DENG Qingfang , Andrew Lunn , Vivien Didelot , Florian Fainelli , "David S . Miller" , Jakub Kicinski , netdev Subject: Re: [PATCH net-next] net: dsa: tag_rtl4_a: Drop bit 9 from egress frames Message-ID: <20210923221200.xygcmxujwqtxajqd@skbuf> References: <20210913143156.1264570-1-linus.walleij@linaro.org> <20210915071901.1315-1-dqfext@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Sep 23, 2021 at 11:59:36PM +0200, Linus Walleij wrote: > On Wed, Sep 15, 2021 at 9:20 AM DENG Qingfang wrote: > > On Mon, Sep 13, 2021 at 04:31:56PM +0200, Linus Walleij wrote: > > > > This drops the code setting bit 9 on egress frames on the > > > Realtek "type A" (RTL8366RB) frames. > > > > FYI, on RTL8366S, bit 9 on egress frames is disable learning. > > > > > This bit was set on ingress frames for unknown reason, > > > > I think it could be the reason why the frame is forwarded to the CPU. > > Hm I suspect it disable learning on RTL8366RB as well. Suspicion based on what? > Do we have some use for that feature in DSA taggers? Yes.