From: Guangbin Huang <huangguangbin2@huawei.com>
To: <davem@davemloft.net>, <kuba@kernel.org>, <mkubecek@suse.cz>,
<andrew@lunn.ch>, <amitc@mellanox.com>, <idosch@idosch.org>,
<danieller@nvidia.com>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <jdike@addtoit.com>,
<richard@nod.at>, <anton.ivanov@cambridgegreys.com>,
<netanel@amazon.com>, <akiyano@amazon.com>, <gtzalik@amazon.com>,
<saeedb@amazon.com>, <chris.snook@gmail.com>,
<ulli.kroll@googlemail.com>, <linus.walleij@linaro.org>,
<jeroendb@google.com>, <csully@google.com>,
<awogbemila@google.com>, <jdmason@kudzu.us>,
<rain.1986.08.12@gmail.com>, <zyjzyj2000@gmail.com>,
<kys@microsoft.com>, <haiyangz@microsoft.com>, <mst@redhat.com>,
<jasowang@redhat.com>, <doshir@vmware.com>,
<pv-drivers@vmware.com>, <jwi@linux.ibm.com>,
<kgraul@linux.ibm.com>, <hca@linux.ibm.com>, <gor@linux.ibm.com>,
<johannes@sipsolutions.net>
Cc: <netdev@vger.kernel.org>, <lipeng321@huawei.com>,
<chenhao288@hisilicon.com>, <huangguangbin2@huawei.com>,
<linux-s390@vger.kernel.org>
Subject: [PATCH V2 net-next 6/6] net: hns3: remove the way to set tx spare buf via module parameter
Date: Fri, 24 Sep 2021 22:29:59 +0800 [thread overview]
Message-ID: <20210924142959.7798-7-huangguangbin2@huawei.com> (raw)
In-Reply-To: <20210924142959.7798-1-huangguangbin2@huawei.com>
From: Hao Chen <chenhao288@hisilicon.com>
The way to set tx spare buf via module parameter is not such
convenient as the way to set it via ethtool.
So,remove the way to set tx spare buf via module parameter.
Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 345dddb2d691..f8edf1d45f01 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -53,10 +53,6 @@ static int debug = -1;
module_param(debug, int, 0);
MODULE_PARM_DESC(debug, " Network interface message level setting");
-static unsigned int tx_spare_buf_size;
-module_param(tx_spare_buf_size, uint, 0400);
-MODULE_PARM_DESC(tx_spare_buf_size, "Size used to allocate tx spare buffer");
-
static unsigned int tx_sgl = 1;
module_param(tx_sgl, uint, 0600);
MODULE_PARM_DESC(tx_sgl, "Minimum number of frags when using dma_map_sg() to optimize the IOMMU mapping");
@@ -1040,8 +1036,7 @@ static void hns3_init_tx_spare_buffer(struct hns3_enet_ring *ring)
dma_addr_t dma;
int order;
- alloc_size = tx_spare_buf_size ? tx_spare_buf_size :
- ring->tqp->handle->kinfo.tx_spare_buf_size;
+ alloc_size = ring->tqp->handle->kinfo.tx_spare_buf_size;
if (!alloc_size)
return;
--
2.33.0
prev parent reply other threads:[~2021-09-24 14:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 14:29 [PATCH V2 net-next 0/6] ethtool: add support to set/get tx copybreak buf size and rx buf len Guangbin Huang
2021-09-24 14:29 ` [PATCH V2 net-next 1/6] ethtool: add support to set/get tx copybreak buf size via ethtool Guangbin Huang
2021-09-24 23:05 ` Michal Kubecek
2021-09-29 2:19 ` huangguangbin (A)
2021-09-24 14:29 ` [PATCH V2 net-next 2/6] net: hns3: add support to set/get tx copybreak buf size via ethtool for hns3 driver Guangbin Huang
2021-09-24 14:29 ` [PATCH V2 net-next 3/6] ethtool: add support to set/get rx buf len via ethtool Guangbin Huang
2021-09-24 17:47 ` Jakub Kicinski
2021-09-29 2:21 ` huangguangbin (A)
2021-09-24 23:14 ` Michal Kubecek
2021-09-29 2:33 ` huangguangbin (A)
2021-09-24 14:29 ` [PATCH V2 net-next 4/6] ethtool: extend ringparam setting uAPI with rx_buf_len Guangbin Huang
2021-09-24 14:57 ` Haiyang Zhang
2021-09-24 14:29 ` [PATCH V2 net-next 5/6] net: hns3: add support to set/get rx buf len via ethtool for hns3 driver Guangbin Huang
2021-09-24 14:29 ` Guangbin Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924142959.7798-7-huangguangbin2@huawei.com \
--to=huangguangbin2@huawei.com \
--cc=akiyano@amazon.com \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=awogbemila@google.com \
--cc=chenhao288@hisilicon.com \
--cc=chris.snook@gmail.com \
--cc=csully@google.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=doshir@vmware.com \
--cc=gor@linux.ibm.com \
--cc=gtzalik@amazon.com \
--cc=haiyangz@microsoft.com \
--cc=hca@linux.ibm.com \
--cc=idosch@idosch.org \
--cc=jasowang@redhat.com \
--cc=jdike@addtoit.com \
--cc=jdmason@kudzu.us \
--cc=jeroendb@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linus.walleij@linaro.org \
--cc=linux-s390@vger.kernel.org \
--cc=lipeng321@huawei.com \
--cc=mkubecek@suse.cz \
--cc=mst@redhat.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pv-drivers@vmware.com \
--cc=rain.1986.08.12@gmail.com \
--cc=richard@nod.at \
--cc=saeedb@amazon.com \
--cc=ulli.kroll@googlemail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).