From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, Roi Dayan <roid@nvidia.com>,
Maor Dickman <maord@nvidia.com>,
Saeed Mahameed <saeedm@nvidia.com>
Subject: [net-next 04/12] net/mlx5e: Remove incorrect addition of action fwd flag
Date: Fri, 24 Sep 2021 11:48:00 -0700 [thread overview]
Message-ID: <20210924184808.796968-5-saeed@kernel.org> (raw)
In-Reply-To: <20210924184808.796968-1-saeed@kernel.org>
From: Roi Dayan <roid@nvidia.com>
A user is expected to explicit request a fwd or drop action.
It is not correct to implicit add a fwd action for the user,
when modify header action flag exists.
Signed-off-by: Roi Dayan <roid@nvidia.com>
Reviewed-by: Maor Dickman <maord@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index f55fc8553664..d68c67b98d94 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -3491,9 +3491,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv,
attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
}
- if (attr->action & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR)
- attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
-
if (!actions_match_supported(priv, flow_action, parse_attr, flow, extack))
return -EOPNOTSUPP;
--
2.31.1
next prev parent reply other threads:[~2021-09-24 18:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-24 18:47 [pull request][net-next 00/12] mlx5 updates 2021-09-24 Saeed Mahameed
2021-09-24 18:47 ` [net-next 01/12] net/mlx5: DR, Fix code indentation in dr_ste_v1 Saeed Mahameed
2021-09-25 10:40 ` patchwork-bot+netdevbpf
2021-09-24 18:47 ` [net-next 02/12] net/mlx5e: Add error flow for ethtool -X command Saeed Mahameed
2021-09-24 18:47 ` [net-next 03/12] net/mlx5e: Use correct return type Saeed Mahameed
2021-09-24 18:48 ` Saeed Mahameed [this message]
2021-09-24 18:48 ` [net-next 05/12] net/mlx5e: Set action fwd flag when parsing tc action goto Saeed Mahameed
2021-09-24 18:48 ` [net-next 06/12] net/mlx5e: Check action fwd/drop flag exists also for nic flows Saeed Mahameed
2021-09-24 18:48 ` [net-next 07/12] net/mlx5e: Remove redundant priv arg from parse_pedit_to_reformat() Saeed Mahameed
2021-09-24 18:48 ` [net-next 08/12] net/mlx5e: Use tc sample stubs instead of ifdefs in source file Saeed Mahameed
2021-09-24 18:48 ` [net-next 09/12] net/mlx5e: Use NL_SET_ERR_MSG_MOD() for errors parsing tunnel attributes Saeed Mahameed
2021-09-24 18:48 ` [net-next 10/12] net/mlx5e: loopback test is not supported in switchdev mode Saeed Mahameed
2021-09-24 18:48 ` [net-next 11/12] net/mlx5e: Enable TC offload for egress MACVLAN Saeed Mahameed
2021-09-24 18:48 ` [net-next 12/12] net/mlx5e: Enable TC offload for ingress MACVLAN Saeed Mahameed
2021-09-25 0:25 ` [pull request][net-next 00/12] mlx5 updates 2021-09-24 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210924184808.796968-5-saeed@kernel.org \
--to=saeed@kernel.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=maord@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).