From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D2D6C433FE for ; Fri, 24 Sep 2021 18:48:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 52A3A61260 for ; Fri, 24 Sep 2021 18:48:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244073AbhIXSuA (ORCPT ); Fri, 24 Sep 2021 14:50:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:46402 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239329AbhIXStw (ORCPT ); Fri, 24 Sep 2021 14:49:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AD57661278; Fri, 24 Sep 2021 18:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632509299; bh=d5ZqYaJG4nHoFIQFDHDv9wUBFTekpdzrqPG2AEeTWPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y9AdO4SnkFOtH17CaCYNFoduqEhMWh+UOZVuMVRO2H73Cq0U109hORkDyeNnHit52 aVMh3exea1rKubgwF6ACBK2LIU0PKfSoZJfBFZrU6ga6aF6rbcHErdvkzXrqGtkF4a kR3LU5hE/CQjMObolUqp6XxrjVSmeGT1jbo4hu2M8elidBH5SKF7cWZv9tRajHqKJR KHHPALVMKDxQsq+slre/4eoWxuX0oFyOXA702Zx/KX5Bc5HONBWWcI5U35RSCDIAYC UDJfsJuuy47Sr+GykqKZq3XIE3pPNsqHfUM9sE4g1Z5L4yHGraPDD/PC86a/TNSVtG 8xa2LwKf9O1Hw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Roi Dayan , Maor Dickman , Saeed Mahameed Subject: [net-next 04/12] net/mlx5e: Remove incorrect addition of action fwd flag Date: Fri, 24 Sep 2021 11:48:00 -0700 Message-Id: <20210924184808.796968-5-saeed@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210924184808.796968-1-saeed@kernel.org> References: <20210924184808.796968-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan A user is expected to explicit request a fwd or drop action. It is not correct to implicit add a fwd action for the user, when modify header action flag exists. Signed-off-by: Roi Dayan Reviewed-by: Maor Dickman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index f55fc8553664..d68c67b98d94 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -3491,9 +3491,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; } - if (attr->action & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR) - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; - if (!actions_match_supported(priv, flow_action, parse_attr, flow, extack)) return -EOPNOTSUPP; -- 2.31.1