From: Dan Carpenter <dan.carpenter@oracle.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
"David S. Miller" <davem@davemloft.net>,
"John W. Linville" <linville@tuxdriver.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] nfc: avoid potential race condition
Date: Mon, 27 Sep 2021 18:13:25 +0300 [thread overview]
Message-ID: <20210927151325.GJ2083@kadam> (raw)
In-Reply-To: <1af270c3-8a4f-6c62-bb6c-b454a507f443@canonical.com>
On Mon, Sep 27, 2021 at 04:58:45PM +0200, Krzysztof Kozlowski wrote:
> On 27/09/2021 16:26, Jakub Kicinski wrote:
> > On Mon, 27 Sep 2021 09:44:08 +0200 Krzysztof Kozlowski wrote:
> >> On 24/09/2021 22:14, Jakub Kicinski wrote:
> >>> On Fri, 24 Sep 2021 10:21:33 +0200 Krzysztof Kozlowski wrote:
> >>>> Indeed. The code looks reasonable, though, so even if race is not really
> >>>> reproducible:
> >>>>
> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> >>>
> >>> Would you mind making a call if this is net (which will mean stable) or
> >>> net-next material (without the Fixes tags) and reposting? Thanks! :)
> >>
> >> Hi Jakub,
> >>
> >> Material is net-next. However I don't understand why it should be
> >> without "Fixes" in such case?
> >>
> >> The material going to current release (RC, so I understood: net), should
> >> fix only issues introduced in current merge window. Linus made it clear
> >> several times.
> >
> > Oh, really? I've never heard about this rule, would you be able to dig
> > up references?
>
> Not that easy to go through thousands of emails, but I'll try:
>
> "One thing that does bother him is developers who send him fixes in the
> -rc2 or -rc3 time frame for things that never worked in the first place.
> If something never worked, then the fact that it doesn't work now is not
> a regression, so the fixes should just wait for the next merge window.
> Those fixes are, after all, essentially development work."
> https://lwn.net/Articles/705245/
Yes. He's talking about fixes to new features which don't work at all.
I once discovered a module that had a bug in probe() and it had never
once been able to probe without crashing. It had been in the kernel for
ten years. The developer was like, "Yeah. We knew it was crap and
wanted to delete it but that was before git and Linus lost the patch."
Anyway, this is a security bug (DoS at the minimum) so it should be
merged into net and set to stable.
regards,
dan carpenter
next prev parent reply other threads:[~2021-09-27 15:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 6:50 [PATCH net] nfc: avoid potential race condition Dan Carpenter
2021-09-23 7:26 ` Krzysztof Kozlowski
2021-09-23 12:22 ` Dan Carpenter
2021-09-24 8:21 ` Krzysztof Kozlowski
2021-09-24 20:14 ` Jakub Kicinski
2021-09-27 7:44 ` Krzysztof Kozlowski
2021-09-27 14:26 ` Jakub Kicinski
2021-09-27 14:58 ` Krzysztof Kozlowski
2021-09-27 15:13 ` Dan Carpenter [this message]
2021-09-27 15:27 ` Krzysztof Kozlowski
2021-09-27 15:38 ` Dan Carpenter
2021-09-27 14:49 ` Dan Carpenter
2021-09-27 12:14 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927151325.GJ2083@kadam \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=kuba@kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).