netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matt Johnston <matt@codeconstruct.com.au>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	netdev@vger.kernel.org
Cc: Jeremy Kerr <jk@codeconstruct.com.au>
Subject: [PATCH net-next 02/10] mctp: Allow local delivery to the null EID
Date: Wed, 29 Sep 2021 15:26:06 +0800	[thread overview]
Message-ID: <20210929072614.854015-3-matt@codeconstruct.com.au> (raw)
In-Reply-To: <20210929072614.854015-1-matt@codeconstruct.com.au>

From: Jeremy Kerr <jk@codeconstruct.com.au>

We may need to receive packets addressed to the null EID (==0), but
addressed to us at the physical layer.

This change adds a lookup for local routes when we see a packet
addressed to EID 0, and a local phys address.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
 net/mctp/route.c | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/net/mctp/route.c b/net/mctp/route.c
index a953f83ed02b..224fd25b3678 100644
--- a/net/mctp/route.c
+++ b/net/mctp/route.c
@@ -474,6 +474,10 @@ static int mctp_alloc_local_tag(struct mctp_sock *msk,
 	int rc = -EAGAIN;
 	u8 tagbits;
 
+	/* for NULL destination EIDs, we may get a response from any peer */
+	if (daddr == MCTP_ADDR_NULL)
+		daddr = MCTP_ADDR_ANY;
+
 	/* be optimistic, alloc now */
 	key = mctp_key_alloc(msk, saddr, daddr, 0, GFP_KERNEL);
 	if (!key)
@@ -552,6 +556,20 @@ struct mctp_route *mctp_route_lookup(struct net *net, unsigned int dnet,
 	return rt;
 }
 
+static struct mctp_route *mctp_route_lookup_null(struct net *net,
+						 struct net_device *dev)
+{
+	struct mctp_route *rt;
+
+	list_for_each_entry_rcu(rt, &net->mctp.routes, list) {
+		if (rt->dev->dev == dev && rt->type == RTN_LOCAL &&
+		    refcount_inc_not_zero(&rt->refs))
+			return rt;
+	}
+
+	return NULL;
+}
+
 /* sends a skb to rt and releases the route. */
 int mctp_do_route(struct mctp_route *rt, struct sk_buff *skb)
 {
@@ -849,6 +867,11 @@ static int mctp_pkttype_receive(struct sk_buff *skb, struct net_device *dev,
 	cb->net = READ_ONCE(mdev->net);
 
 	rt = mctp_route_lookup(net, cb->net, mh->dest);
+
+	/* NULL EID, but addressed to our physical address */
+	if (!rt && mh->dest == MCTP_ADDR_NULL && skb->pkt_type == PACKET_HOST)
+		rt = mctp_route_lookup_null(net, dev);
+
 	if (!rt)
 		goto err_drop;
 
-- 
2.30.2


  parent reply	other threads:[~2021-09-29  7:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29  7:26 [PATCH net-next 00/10] Updates to MCTP core Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 01/10] mctp: Allow MCTP on tun devices Matt Johnston
2021-09-29  7:26 ` Matt Johnston [this message]
2021-09-29  7:26 ` [PATCH net-next 03/10] mctp: locking, lifetime and validity changes for sk_keys Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 04/10] mctp: Add refcounts to mctp_dev Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 05/10] mctp: Implement a timeout for tags Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 06/10] mctp: Add tracepoints for tag/key handling Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 07/10] mctp: Do inits as a subsys_initcall Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 08/10] doc/mctp: Add a little detail about kernel internals Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 09/10] mctp: Set route MTU via netlink Matt Johnston
2021-09-29  7:26 ` [PATCH net-next 10/10] mctp: Warn if pointer is set for a wrong dev type Matt Johnston
2021-09-29 10:10 ` [PATCH net-next 00/10] Updates to MCTP core patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210929072614.854015-3-matt@codeconstruct.com.au \
    --to=matt@codeconstruct.com.au \
    --cc=davem@davemloft.net \
    --cc=jk@codeconstruct.com.au \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).