From: Ido Schimmel <idosch@idosch.org>
To: netdev@vger.kernel.org
Cc: mkubecek@suse.cz, popadrian1996@gmail.com, mlxsw@nvidia.com,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH ethtool-next v2 4/7] sff-8636: Remove incorrect comment
Date: Fri, 1 Oct 2021 18:06:24 +0300 [thread overview]
Message-ID: <20211001150627.1353209-5-idosch@idosch.org> (raw)
In-Reply-To: <20211001150627.1353209-1-idosch@idosch.org>
From: Ido Schimmel <idosch@nvidia.com>
The comment was copied from SFF-8472 (i.e., sfpdiag.c) where the
diagnostic page is at I2C address 0x51. SFF-8636 only uses I2C address
0x50.
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
---
qsfp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qsfp.c b/qsfp.c
index e84226bc1554..263cf188377d 100644
--- a/qsfp.c
+++ b/qsfp.c
@@ -64,7 +64,7 @@
static struct sff8636_aw_flags {
const char *str; /* Human-readable string, null at the end */
- int offset; /* A2-relative address offset */
+ int offset;
__u8 value; /* Alarm is on if (offset & value) != 0. */
} sff8636_aw_flags[] = {
{ "Laser bias current high alarm (Chan 1)",
--
2.31.1
next prev parent reply other threads:[~2021-10-01 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-01 15:06 [PATCH ethtool-next v2 0/7] ethtool: Small EEPROM changes Ido Schimmel
2021-10-01 15:06 ` [PATCH ethtool-next v2 1/7] cmis: Fix CLEI code parsing Ido Schimmel
2021-10-01 15:06 ` [PATCH ethtool-next v2 2/7] cmis: Fix wrong define name Ido Schimmel
2021-10-01 15:06 ` [PATCH ethtool-next v2 3/7] cmis: Correct comment Ido Schimmel
2021-10-01 15:06 ` Ido Schimmel [this message]
2021-10-01 15:06 ` [PATCH ethtool-next v2 5/7] sff-8636: Fix incorrect function name Ido Schimmel
2021-10-01 15:06 ` [PATCH ethtool-next v2 6/7] sff-8636: Convert if statement to switch-case Ido Schimmel
2021-10-01 15:06 ` [PATCH ethtool-next v2 7/7] sff-8636: Remove extra blank lines Ido Schimmel
2021-10-08 12:32 ` [PATCH ethtool-next v2 0/7] ethtool: Small EEPROM changes Ido Schimmel
2021-10-11 10:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211001150627.1353209-5-idosch@idosch.org \
--to=idosch@idosch.org \
--cc=idosch@nvidia.com \
--cc=mkubecek@suse.cz \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=popadrian1996@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).