From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33115C433F5 for ; Sat, 2 Oct 2021 13:02:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 168F161ACE for ; Sat, 2 Oct 2021 13:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233233AbhJBNDr (ORCPT ); Sat, 2 Oct 2021 09:03:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45984 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233093AbhJBNDp (ORCPT ); Sat, 2 Oct 2021 09:03:45 -0400 Received: from mail.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29669C0613EC for ; Sat, 2 Oct 2021 06:02:00 -0700 (PDT) Received: from localhost (cpc147930-brnt3-2-0-cust60.4-2.cable.virginm.net [86.15.196.61]) by mail.monkeyblade.net (Postfix) with ESMTPSA id 91B9E4F804CBE; Sat, 2 Oct 2021 06:01:57 -0700 (PDT) Date: Sat, 02 Oct 2021 14:01:52 +0100 (BST) Message-Id: <20211002.140152.1798934215442988990.davem@davemloft.net> To: jk@codeconstruct.com.au Cc: netdev@vger.kernel.org, kuba@kernel.org, matt@codeconstruct.com.au, brendanhiggins@google.com, linux-kselftest@vger.kernel.org Subject: Re: [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module From: David Miller In-Reply-To: <20211002022656.1681956-1-jk@codeconstruct.com.au> References: <20211002022656.1681956-1-jk@codeconstruct.com.au> X-Mailer: Mew version 6.8 on Emacs 27.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.6.2 (mail.monkeyblade.net [0.0.0.0]); Sat, 02 Oct 2021 06:01:59 -0700 (PDT) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jeremy Kerr Date: Sat, 2 Oct 2021 10:26:55 +0800 > The current kunit infrastructure defines its own module_init() when > built as a module, which conflicts with the mctp core's own. > > So, only allow MCTP_TEST when both MCTP and KUNIT are built-in. > > Reported-by: kernel test robot > Signed-off-by: Jeremy Kerr Jeremy I had to revert your entire series because of this. You will need rseubmit the entire series with this build failure fixed. Thasnk you.