From: Jeremy Kerr <jk@codeconstruct.com.au>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matt Johnston <matt@codeconstruct.com.au>,
Brendan Higgins <brendanhiggins@google.com>,
linux-kselftest@vger.kernel.org
Subject: [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered
Date: Sat, 2 Oct 2021 10:26:56 +0800 [thread overview]
Message-ID: <20211002022656.1681956-2-jk@codeconstruct.com.au> (raw)
In-Reply-To: <20211002022656.1681956-1-jk@codeconstruct.com.au>
The MCTP device isn't available until we've registered the netdev, so
defer storing our convenience pointer.
Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
---
net/mctp/test/utils.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/net/mctp/test/utils.c b/net/mctp/test/utils.c
index e2ab1f3da357..cc6b8803aa9d 100644
--- a/net/mctp/test/utils.c
+++ b/net/mctp/test/utils.c
@@ -46,17 +46,17 @@ struct mctp_test_dev *mctp_test_create_dev(void)
dev = netdev_priv(ndev);
dev->ndev = ndev;
- rcu_read_lock();
- dev->mdev = __mctp_dev_get(ndev);
- mctp_dev_hold(dev->mdev);
- rcu_read_unlock();
-
rc = register_netdev(ndev);
if (rc) {
free_netdev(ndev);
return NULL;
}
+ rcu_read_lock();
+ dev->mdev = __mctp_dev_get(ndev);
+ mctp_dev_hold(dev->mdev);
+ rcu_read_unlock();
+
return dev;
}
--
2.30.2
next prev parent reply other threads:[~2021-10-02 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 2:26 [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module Jeremy Kerr
2021-10-02 2:26 ` Jeremy Kerr [this message]
2021-10-02 3:16 ` [PATCH net-next 2/2] mctp: test: defer mdev setup until we've registered David Gow
2021-10-03 3:24 ` Jeremy Kerr
2021-10-02 3:10 ` [PATCH net-next 1/2] mctp: test: disallow MCTP_TEST when building as a module David Gow
2021-10-02 13:01 ` David Miller
2021-10-03 2:22 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211002022656.1681956-2-jk@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=brendanhiggins@google.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).