From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Tobias Waldekranz <tobias@waldekranz.com>,
Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH net] dsa: tag_dsa: Fix mask for trunked packets
Date: Sun, 3 Oct 2021 21:07:24 +0000 [thread overview]
Message-ID: <20211003210724.72ns3bi775swppox@skbuf> (raw)
In-Reply-To: <20211003155053.2241209-1-andrew@lunn.ch>
On Sun, Oct 03, 2021 at 05:50:53PM +0200, Andrew Lunn wrote:
> A packet received on a trunk will have bit 2 set in Forward DSA tagged
> frame. Bit 1 can be either 0 or 1 and is otherwise undefined and bit 0
> indicates the frame CFI. Masking with 7 thus results in frames as
> being identified as being from a trunk when in fact they are not. Fix
> the mask to just look at bit 2.
>
> Fixes: 5b60dadb71db ("net: dsa: tag_dsa: Support reception of packets from LAG devices")
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
At least this appears correct on 88E6096/97, but I would expect it to be
true for the entire family.
Would like to hear Tobias' feedback too, though.
next prev parent reply other threads:[~2021-10-03 21:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-03 15:50 [PATCH net] dsa: tag_dsa: Fix mask for trunked packets Andrew Lunn
2021-10-03 21:07 ` Vladimir Oltean [this message]
2021-10-04 12:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211003210724.72ns3bi775swppox@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=tobias@waldekranz.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox