* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review [not found] <20211004125033.572932188@linuxfoundation.org> @ 2021-10-04 17:40 ` Naresh Kamboju 2021-10-04 17:44 ` Eric Dumazet 2021-10-04 17:52 ` Pavel Machek 0 siblings, 2 replies; 6+ messages in thread From: Naresh Kamboju @ 2021-10-04 17:40 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Eric Dumazet, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > This is the start of the stable review cycle for the 4.19.209 release. > There are 95 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. > Anything received after that time might be too late. > > The whole patch series can be found in one patch at: > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz > or in the git tree and branch at: > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > and the diffstat can be found below. > > thanks, > > greg k-h Regression found on arm, arm64, i386 and x86. following kernel crash reported on stable-rc linux-4.19.y. metadata: git branch: linux-4.19.y git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc git commit: ee3e528d83e91547f386a30677ccb96c28e78218 git describe: v4.19.208-96-gee3e528d83e9 make_kernelversion: 4.19.209-rc1 kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config Kernel crash: -------------- [ 14.900875] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000 [ 14.908699] PGD 0 P4D 0 [ 14.911230] Oops: 0002 [#1] SMP PTI [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS 2.2 05/23/2018 [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 14.951704] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 14.956920] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 14.964043] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 14.971167] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 14.978291] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 14.985415] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 14.992540] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.000617] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.006359] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.013504] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.020628] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.027752] Call Trace: [ 15.030198] <IRQ> [ 15.032207] __sk_free+0x71/0x110 [ 15.035518] __sock_wfree+0x2c/0x30 [ 15.039002] skb_release_head_state+0x56/0xa0 [ 15.043359] napi_consume_skb+0x5a/0x140 [ 15.047297] igb_poll+0xc7/0xf30 [ 15.050522] net_rx_action+0x13a/0x3a0 [ 15.054273] ? __napi_schedule+0x54/0x70 [ 15.058189] __do_softirq+0xf6/0x2ed [ 15.061760] irq_exit+0xab/0xe0 [ 15.064897] do_IRQ+0x86/0xe0 [ 15.067862] common_interrupt+0xf/0xf [ 15.071519] </IRQ> [ 15.073618] RIP: 0010:cpuidle_enter_state+0x119/0x2c0 [ 15.078669] Code: 77 ff 80 7d c7 00 74 12 9c 58 f6 c4 02 0f 85 8e 01 00 00 31 ff e8 07 1d 7d ff e8 b2 84 82 ff fb 48 ba cf f7 53 e3 a5 9b c4 20 <4c> 2b 7d c8 4c 89 f8 49 c1 ff 3f 48 f7 ea b8 ff ff ff 7f 48 c1 fa [ 15.097405] RSP: 0000:ffffffff9ce03e00 EFLAGS: 00000282 ORIG_RAX: ffffffffffffffdc [ 15.104961] RAX: ffffffff9ce03e40 RBX: ffff9e242d6ce000 RCX: 000000000000001f [ 15.112085] RDX: 20c49ba5e353f7cf RSI: ffffffff9c028777 RDI: ffffffff9c02858e [ 15.119210] RBP: ffffffff9ce03e40 R08: 0000000378293f7f R09: 0000000000000022 [ 15.126358] R10: 0000000000000034 R11: ffff9e242f81ed08 R12: 0000000000000001 [ 15.133510] R13: ffffffff9ceca620 R14: ffffffff9ceca680 R15: 0000000378293f7f [ 15.140636] ? cpuidle_enter+0x17/0x20 [ 15.144415] ? cpuidle_enter_state+0x10e/0x2c0 [ 15.148859] cpuidle_enter+0x17/0x20 [ 15.152430] call_cpuidle+0x23/0x40 [ 15.155914] do_idle+0x1b9/0x240 [ 15.159138] cpu_startup_entry+0x73/0x80 [ 15.163055] rest_init+0xa3/0xa5 [ 15.166280] start_kernel+0x483/0x4a5 [ 15.169937] x86_64_start_reservations+0x24/0x26 [ 15.174547] x86_64_start_kernel+0x70/0x74 [ 15.178637] secondary_startup_64+0xa4/0xb0 [ 15.182813] Modules linked in: [ 15.185866] CR2: 0000000000000000 [ 15.189177] ---[ end trace 87e25bcdd88d2b4b ]--- [ 15.193785] RIP: 0010:__sk_destruct+0xb9/0x190 [ 15.198222] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d ff f6 [ 15.216960] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 [ 15.222176] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 [ 15.229302] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 15.236424] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 [ 15.243548] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 [ 15.250673] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c [ 15.257796] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) knlGS:0000000000000000 [ 15.265872] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 15.271613] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 [ 15.278734] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 15.285858] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 15.292982] Kernel panic - not syncing: Fatal exception in interrupt [ 15.299375] Kernel Offset: 0x1a600000 from 0xffffffff81000000 (relocation range: 0xffffffff80000000-0xffffffffbfffffff) Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> ref: https://lkft.validation.linaro.org/scheduler/job/3657592#L928 https://lkft.validation.linaro.org/scheduler/job/3657638#L933 https://lkft.validation.linaro.org/scheduler/job/3657762#L949 https://lkft.validation.linaro.org/scheduler/job/3657822#L1899 -- Linaro LKFT https://lkft.linaro.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review 2021-10-04 17:40 ` [PATCH 4.19 00/95] 4.19.209-rc1 review Naresh Kamboju @ 2021-10-04 17:44 ` Eric Dumazet 2021-10-04 19:49 ` Shuah Khan 2021-10-05 6:47 ` Greg Kroah-Hartman 2021-10-04 17:52 ` Pavel Machek 1 sibling, 2 replies; 6+ messages in thread From: Eric Dumazet @ 2021-10-04 17:44 UTC (permalink / raw) To: Naresh Kamboju Cc: Greg Kroah-Hartman, open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju <naresh.kamboju@linaro.org> wrote: > > On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > This is the start of the stable review cycle for the 4.19.209 release. > > There are 95 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > Regression found on arm, arm64, i386 and x86. > following kernel crash reported on stable-rc linux-4.19.y. > Stable teams should backport cred: allow get_cred() and put_cred() to be given NULL. f06bc03339ad4c1baa964a5f0606247ac1c3c50b Or they should have tweaked my patch before backporting it. > metadata: > git branch: linux-4.19.y > git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc > git commit: ee3e528d83e91547f386a30677ccb96c28e78218 > git describe: v4.19.208-96-gee3e528d83e9 > make_kernelversion: 4.19.209-rc1 > kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config > > > Kernel crash: > -------------- > [ 14.900875] BUG: unable to handle kernel NULL pointer dereference > at 0000000000000000 > [ 14.908699] PGD 0 P4D 0 > [ 14.911230] Oops: 0002 [#1] SMP PTI > [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 > [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > 2.2 05/23/2018 > [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 > [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff > 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 > ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d > ff f6 > [ 14.951704] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 > [ 14.956920] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 > [ 14.964043] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > [ 14.971167] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 > [ 14.978291] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 > [ 14.985415] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c > [ 14.992540] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) > knlGS:0000000000000000 > [ 15.000617] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 15.006359] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 > [ 15.013504] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 15.020628] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 15.027752] Call Trace: > [ 15.030198] <IRQ> > [ 15.032207] __sk_free+0x71/0x110 > [ 15.035518] __sock_wfree+0x2c/0x30 > [ 15.039002] skb_release_head_state+0x56/0xa0 > [ 15.043359] napi_consume_skb+0x5a/0x140 > [ 15.047297] igb_poll+0xc7/0xf30 > [ 15.050522] net_rx_action+0x13a/0x3a0 > [ 15.054273] ? __napi_schedule+0x54/0x70 > [ 15.058189] __do_softirq+0xf6/0x2ed > [ 15.061760] irq_exit+0xab/0xe0 > [ 15.064897] do_IRQ+0x86/0xe0 > [ 15.067862] common_interrupt+0xf/0xf > [ 15.071519] </IRQ> > [ 15.073618] RIP: 0010:cpuidle_enter_state+0x119/0x2c0 > [ 15.078669] Code: 77 ff 80 7d c7 00 74 12 9c 58 f6 c4 02 0f 85 8e > 01 00 00 31 ff e8 07 1d 7d ff e8 b2 84 82 ff fb 48 ba cf f7 53 e3 a5 > 9b c4 20 <4c> 2b 7d c8 4c 89 f8 49 c1 ff 3f 48 f7 ea b8 ff ff ff 7f 48 > c1 fa > [ 15.097405] RSP: 0000:ffffffff9ce03e00 EFLAGS: 00000282 ORIG_RAX: > ffffffffffffffdc > [ 15.104961] RAX: ffffffff9ce03e40 RBX: ffff9e242d6ce000 RCX: 000000000000001f > [ 15.112085] RDX: 20c49ba5e353f7cf RSI: ffffffff9c028777 RDI: ffffffff9c02858e > [ 15.119210] RBP: ffffffff9ce03e40 R08: 0000000378293f7f R09: 0000000000000022 > [ 15.126358] R10: 0000000000000034 R11: ffff9e242f81ed08 R12: 0000000000000001 > [ 15.133510] R13: ffffffff9ceca620 R14: ffffffff9ceca680 R15: 0000000378293f7f > [ 15.140636] ? cpuidle_enter+0x17/0x20 > [ 15.144415] ? cpuidle_enter_state+0x10e/0x2c0 > [ 15.148859] cpuidle_enter+0x17/0x20 > [ 15.152430] call_cpuidle+0x23/0x40 > [ 15.155914] do_idle+0x1b9/0x240 > [ 15.159138] cpu_startup_entry+0x73/0x80 > [ 15.163055] rest_init+0xa3/0xa5 > [ 15.166280] start_kernel+0x483/0x4a5 > [ 15.169937] x86_64_start_reservations+0x24/0x26 > [ 15.174547] x86_64_start_kernel+0x70/0x74 > [ 15.178637] secondary_startup_64+0xa4/0xb0 > [ 15.182813] Modules linked in: > [ 15.185866] CR2: 0000000000000000 > [ 15.189177] ---[ end trace 87e25bcdd88d2b4b ]--- > [ 15.193785] RIP: 0010:__sk_destruct+0xb9/0x190 > [ 15.198222] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff > 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 > ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d > ff f6 > [ 15.216960] RSP: 0000:ffff9e242f803dc0 EFLAGS: 00010246 > [ 15.222176] RAX: 0000000000000000 RBX: ffff9e242cfc82c0 RCX: 0000000000000001 > [ 15.229302] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 > [ 15.236424] RBP: ffff9e242f803de0 R08: ffff9e242cfc8000 R09: 0000000000000000 > [ 15.243548] R10: 0000000000000000 R11: 0000000000000000 R12: ffff9e242cfc8000 > [ 15.250673] R13: ffff9e242cfc82c0 R14: ffff9e242cde8600 R15: 00000000ffffff0c > [ 15.257796] FS: 0000000000000000(0000) GS:ffff9e242f800000(0000) > knlGS:0000000000000000 > [ 15.265872] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 15.271613] CR2: 0000000000000000 CR3: 0000000013c0a001 CR4: 00000000003606f0 > [ 15.278734] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 15.285858] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 15.292982] Kernel panic - not syncing: Fatal exception in interrupt > [ 15.299375] Kernel Offset: 0x1a600000 from 0xffffffff81000000 > (relocation range: 0xffffffff80000000-0xffffffffbfffffff) > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > ref: > https://lkft.validation.linaro.org/scheduler/job/3657592#L928 > https://lkft.validation.linaro.org/scheduler/job/3657638#L933 > https://lkft.validation.linaro.org/scheduler/job/3657762#L949 > https://lkft.validation.linaro.org/scheduler/job/3657822#L1899 > > -- > Linaro LKFT > https://lkft.linaro.org ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review 2021-10-04 17:44 ` Eric Dumazet @ 2021-10-04 19:49 ` Shuah Khan 2021-10-04 20:34 ` Shuah Khan 2021-10-05 6:47 ` Greg Kroah-Hartman 1 sibling, 1 reply; 6+ messages in thread From: Shuah Khan @ 2021-10-04 19:49 UTC (permalink / raw) To: Eric Dumazet, Naresh Kamboju Cc: Greg Kroah-Hartman, open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller, Shuah Khan On 10/4/21 11:44 AM, Eric Dumazet wrote: > On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju > <naresh.kamboju@linaro.org> wrote: >> >> On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman >> <gregkh@linuxfoundation.org> wrote: >>> >>> This is the start of the stable review cycle for the 4.19.209 release. >>> There are 95 patches in this series, all will be posted as a response >>> to this one. If anyone has any issues with these being applied, please >>> let me know. >>> >>> Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. >>> Anything received after that time might be too late. >>> >>> The whole patch series can be found in one patch at: >>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz >>> or in the git tree and branch at: >>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y >>> and the diffstat can be found below. >>> >>> thanks, >>> >>> greg k-h >> >> Regression found on arm, arm64, i386 and x86. >> following kernel crash reported on stable-rc linux-4.19.y. >> > > Stable teams should backport cred: allow get_cred() and put_cred() to > be given NULL. > > f06bc03339ad4c1baa964a5f0606247ac1c3c50b > > Or they should have tweaked my patch before backporting it. > Seeing the same problem on my test system as well. Patch applied with fuzz. Didn't need any tweaks. Compiling now. Will let you know soon. thanks, -- Shuah ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review 2021-10-04 19:49 ` Shuah Khan @ 2021-10-04 20:34 ` Shuah Khan 0 siblings, 0 replies; 6+ messages in thread From: Shuah Khan @ 2021-10-04 20:34 UTC (permalink / raw) To: Eric Dumazet, Naresh Kamboju Cc: Greg Kroah-Hartman, open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller, Shuah Khan On 10/4/21 1:49 PM, Shuah Khan wrote: > On 10/4/21 11:44 AM, Eric Dumazet wrote: >> On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju >> <naresh.kamboju@linaro.org> wrote: >>> >>> On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman >>> <gregkh@linuxfoundation.org> wrote: >>>> >>>> This is the start of the stable review cycle for the 4.19.209 release. >>>> There are 95 patches in this series, all will be posted as a response >>>> to this one. If anyone has any issues with these being applied, please >>>> let me know. >>>> >>>> Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. >>>> Anything received after that time might be too late. >>>> >>>> The whole patch series can be found in one patch at: >>>> https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz >>>> or in the git tree and branch at: >>>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y >>>> and the diffstat can be found below. >>>> >>>> thanks, >>>> >>>> greg k-h >>> >>> Regression found on arm, arm64, i386 and x86. >>> following kernel crash reported on stable-rc linux-4.19.y. >>> >> >> Stable teams should backport cred: allow get_cred() and put_cred() to >> be given NULL. >> >> f06bc03339ad4c1baa964a5f0606247ac1c3c50b >> >> Or they should have tweaked my patch before backporting it. >> > Seeing the same problem on my test system as well. > > Patch applied with fuzz. Didn't need any tweaks. Compiling now. > Will let you know soon. > With f06bc03339ad4c1baa964a5f0606247ac1c3c50b Compiled and booted on my test system. No dmesg regressions. Tested-by: Shuah Khan <skhan@linuxfoundation.org> ----------------------------------------------------------------------- diff --git a/include/linux/cred.h b/include/linux/cred.h index 1dc351d8548b..4b081e4911c8 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h @@ -240,7 +240,7 @@ static inline struct cred *get_new_cred(struct cred *cred) * @cred: The credentials to reference * * Get a reference on the specified set of credentials. The caller must - * release the reference. + * release the reference. If %NULL is passed, it is returned with no action. * * This is used to deal with a committed set of credentials. Although the * pointer is const, this will temporarily discard the const and increment the @@ -251,6 +251,8 @@ static inline struct cred *get_new_cred(struct cred *cred) static inline const struct cred *get_cred(const struct cred *cred) { struct cred *nonconst_cred = (struct cred *) cred; + if (!cred) + return cred; validate_creds(cred); nonconst_cred->non_rcu = 0; return get_new_cred(nonconst_cred); @@ -261,7 +263,7 @@ static inline const struct cred *get_cred(const struct cred *cred) * @cred: The credentials to release * * Release a reference to a set of credentials, deleting them when the last ref - * is released. + * is released. If %NULL is passed, nothing is done. * * This takes a const pointer to a set of credentials because the credentials * on task_struct are attached by const pointers to prevent accidental @@ -271,9 +273,11 @@ static inline void put_cred(const struct cred *_cred) { struct cred *cred = (struct cred *) _cred; - validate_creds(cred); - if (atomic_dec_and_test(&(cred)->usage)) - __put_cred(cred); + if (cred) { + validate_creds(cred); + if (atomic_dec_and_test(&(cred)->usage)) + __put_cred(cred); + } } /** ----------------------------------------------------------------------- thanks, -- Shuah ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review 2021-10-04 17:44 ` Eric Dumazet 2021-10-04 19:49 ` Shuah Khan @ 2021-10-05 6:47 ` Greg Kroah-Hartman 1 sibling, 0 replies; 6+ messages in thread From: Greg Kroah-Hartman @ 2021-10-05 6:47 UTC (permalink / raw) To: Eric Dumazet Cc: Naresh Kamboju, open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller On Mon, Oct 04, 2021 at 10:44:50AM -0700, Eric Dumazet wrote: > On Mon, Oct 4, 2021 at 10:40 AM Naresh Kamboju > <naresh.kamboju@linaro.org> wrote: > > > > On Mon, 4 Oct 2021 at 18:32, Greg Kroah-Hartman > > <gregkh@linuxfoundation.org> wrote: > > > > > > This is the start of the stable review cycle for the 4.19.209 release. > > > There are 95 patches in this series, all will be posted as a response > > > to this one. If anyone has any issues with these being applied, please > > > let me know. > > > > > > Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. > > > Anything received after that time might be too late. > > > > > > The whole patch series can be found in one patch at: > > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz > > > or in the git tree and branch at: > > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > > and the diffstat can be found below. > > > > > > thanks, > > > > > > greg k-h > > > > Regression found on arm, arm64, i386 and x86. > > following kernel crash reported on stable-rc linux-4.19.y. > > > > Stable teams should backport cred: allow get_cred() and put_cred() to > be given NULL. > > f06bc03339ad4c1baa964a5f0606247ac1c3c50b > > Or they should have tweaked my patch before backporting it. Thanks, I have now queued that up, it was not obvious that was a prerequisite for your change :) greg k-h ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4.19 00/95] 4.19.209-rc1 review 2021-10-04 17:40 ` [PATCH 4.19 00/95] 4.19.209-rc1 review Naresh Kamboju 2021-10-04 17:44 ` Eric Dumazet @ 2021-10-04 17:52 ` Pavel Machek 1 sibling, 0 replies; 6+ messages in thread From: Pavel Machek @ 2021-10-04 17:52 UTC (permalink / raw) To: Naresh Kamboju Cc: Greg Kroah-Hartman, open list, Shuah Khan, Florian Fainelli, patches, lkft-triage, Jon Hunter, linux-stable, Pavel Machek, Andrew Morton, Linus Torvalds, Guenter Roeck, Netdev, Eric Dumazet, Jann Horn, Eric W. Biederman, Luiz Augusto von Dentz, Marcel Holtmann, David S. Miller [-- Attachment #1: Type: text/plain, Size: 3159 bytes --] Hi! > > This is the start of the stable review cycle for the 4.19.209 release. > > There are 95 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with these being applied, please > > let me know. > > > > Responses should be made by Wed, 06 Oct 2021 12:50:17 +0000. > > Anything received after that time might be too late. > > > > The whole patch series can be found in one patch at: > > https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.209-rc1.gz > > or in the git tree and branch at: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y > > and the diffstat can be found below. > > > > thanks, > > > > greg k-h > > Regression found on arm, arm64, i386 and x86. > following kernel crash reported on stable-rc linux-4.19.y. > > metadata: > git branch: linux-4.19.y > git repo: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc > git commit: ee3e528d83e91547f386a30677ccb96c28e78218 > git describe: v4.19.208-96-gee3e528d83e9 > make_kernelversion: 4.19.209-rc1 > kernel-config: https://builds.tuxbuild.com/1z2izwX1xMgF2OSYM5EN6ELHEij/config > > > Kernel crash: > -------------- > [ 14.900875] BUG: unable to handle kernel NULL pointer dereference > at 0000000000000000 > [ 14.908699] PGD 0 P4D 0 > [ 14.911230] Oops: 0002 [#1] SMP PTI > [ 14.914714] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1 #1 > [ 14.921147] Hardware name: Supermicro SYS-5019S-ML/X11SSH-F, BIOS > 2.2 05/23/2018 > [ 14.928531] RIP: 0010:__sk_destruct+0xb9/0x190 > [ 14.932965] Code: 48 8b 47 08 48 8d 50 ff a8 01 48 0f 45 fa f0 ff > 4f 34 0f 84 d9 00 00 00 48 c7 83 00 ff ff ff 00 00 00 00 48 8b bb 78 > ff ff ff <f0> ff 0f 0f 84 a0 00 00 00 48 8b bb 70 ff ff ff e8 32 41 6d > ff f6 I believe we see the same failure in testing: https://lava.ciplatform.org/scheduler/job/455022 [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Linux version 4.19.209-rc1-gee3e528d83e9-dirty (root@runner-ryfx8chz-project-14394223-concurrent-0xchkx) () #1 SMP Mon Oct 4 17:14:39 UTC 2021 [ 0.000000] CPU: ARMv7 Processor [413fc0f2] revision 2 (ARMv7), cr=10c5387d [ 0.000000] CPU: div instructions available: patching division code ... [ 7.215118] nameserver0=192.168.1.1 [ 7.228063] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [ 7.236165] pgd = (ptrval) [ 7.238867] [00000000] *pgd=00000000 [ 7.242442] Internal error: Oops: 5 [#1] SMP ARM [ 7.247055] Modules linked in: [ 7.250110] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.209-rc1-gee3e528d83e9-dirty #1 [ 7.258286] Hardware name: Generic RZ/G1 (Flattened Device Tree) [ 7.264318] PC is at __sk_destruct+0xa8/0x11c [ 7.268690] LR is at __sk_destruct+0x4c/0x11c [ 7.273058] pc : [<c0ce244c>] lr : [<c0ce23f0>] psr: 60000113 Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 195 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-05 6:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20211004125033.572932188@linuxfoundation.org>
2021-10-04 17:40 ` [PATCH 4.19 00/95] 4.19.209-rc1 review Naresh Kamboju
2021-10-04 17:44 ` Eric Dumazet
2021-10-04 19:49 ` Shuah Khan
2021-10-04 20:34 ` Shuah Khan
2021-10-05 6:47 ` Greg Kroah-Hartman
2021-10-04 17:52 ` Pavel Machek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).