linux-next: build failure after merge of the net-next tree

linux-next: build failure after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1368 bytes --]

Hi all,

After merging the net-next tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_setup_single_port':
drivers/net/ethernet/ibm/ehea/ehea_main.c:2989:23: error: passing argument 2 of 'eth_hw_addr_set' from incompatible pointer type [-Werror=incompatible-pointer-types]
 2989 |  eth_hw_addr_set(dev, &port->mac_addr);
      |                       ^~~~~~~~~~~~~~~
      |                       |
      |                       u64 * {aka long long unsigned int *}
In file included from include/linux/if_vlan.h:11,
                 from include/linux/filter.h:19,
                 from include/net/sock.h:59,
                 from include/linux/tcp.h:19,
                 from drivers/net/ethernet/ibm/ehea/ehea_main.c:20:
include/linux/etherdevice.h:309:70: note: expected 'const u8 *' {aka 'const unsigned char *'} but argument is of type 'u64 *' {aka 'long long unsigned int *'}
  309 | static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
      |                                                            ~~~~~~~~~~^~~~
cc1: some warnings being treated as errors

Caused by commit

  a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")

I have used the net-next tree from next-20211001 for today.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[PATCH net-next] ethernet: ehea: add missing cast

[Jakub Kicinski]

We need to cast the pointer, unlike memcpy() eth_hw_addr_set()
does not take void *. The driver already casts &port->mac_addr
to u8 * in other places.

Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
 drivers/net/ethernet/ibm/ehea/ehea_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ibm/ehea/ehea_main.c b/drivers/net/ethernet/ibm/ehea/ehea_main.c
index 49e8de42af9a..bad94e4d50f4 100644
--- a/drivers/net/ethernet/ibm/ehea/ehea_main.c
+++ b/drivers/net/ethernet/ibm/ehea/ehea_main.c
@@ -2986,7 +2986,7 @@ static struct ehea_port *ehea_setup_single_port(struct ehea_adapter *adapter,
 	SET_NETDEV_DEV(dev, port_dev);
 
 	/* initialize net_device structure */
-	eth_hw_addr_set(dev, &port->mac_addr);
+	eth_hw_addr_set(dev, (u8 *)&port->mac_addr);
 
 	dev->netdev_ops = &ehea_netdev_ops;
 	ehea_set_ethtool_ops(dev);
-- 
2.31.1

Re: linux-next: build failure after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1641 bytes --]

Hi all,

On Tue, 5 Oct 2021 11:56:37 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the net-next tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
> 
> drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_setup_single_port':
> drivers/net/ethernet/ibm/ehea/ehea_main.c:2989:23: error: passing argument 2 of 'eth_hw_addr_set' from incompatible pointer type [-Werror=incompatible-pointer-types]
>  2989 |  eth_hw_addr_set(dev, &port->mac_addr);
>       |                       ^~~~~~~~~~~~~~~
>       |                       |
>       |                       u64 * {aka long long unsigned int *}
> In file included from include/linux/if_vlan.h:11,
>                  from include/linux/filter.h:19,
>                  from include/net/sock.h:59,
>                  from include/linux/tcp.h:19,
>                  from drivers/net/ethernet/ibm/ehea/ehea_main.c:20:
> include/linux/etherdevice.h:309:70: note: expected 'const u8 *' {aka 'const unsigned char *'} but argument is of type 'u64 *' {aka 'long long unsigned int *'}
>   309 | static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
>       |                                                            ~~~~~~~~~~^~~~
> cc1: some warnings being treated as errors
> 
> Caused by commit
> 
>   a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")
> 
> I have used the net-next tree from next-20211001 for today.

I also had to use the next-20211001 version if the bpf-next tree (since
it had been reset past the broken commit in the net-next tree).

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: build failure after merge of the net-next tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]

Hi all,

On Tue, 5 Oct 2021 12:24:07 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi all,
> 
> On Tue, 5 Oct 2021 11:56:37 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > After merging the net-next tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> > 
> > drivers/net/ethernet/ibm/ehea/ehea_main.c: In function 'ehea_setup_single_port':
> > drivers/net/ethernet/ibm/ehea/ehea_main.c:2989:23: error: passing argument 2 of 'eth_hw_addr_set' from incompatible pointer type [-Werror=incompatible-pointer-types]
> >  2989 |  eth_hw_addr_set(dev, &port->mac_addr);
> >       |                       ^~~~~~~~~~~~~~~
> >       |                       |
> >       |                       u64 * {aka long long unsigned int *}
> > In file included from include/linux/if_vlan.h:11,
> >                  from include/linux/filter.h:19,
> >                  from include/net/sock.h:59,
> >                  from include/linux/tcp.h:19,
> >                  from drivers/net/ethernet/ibm/ehea/ehea_main.c:20:
> > include/linux/etherdevice.h:309:70: note: expected 'const u8 *' {aka 'const unsigned char *'} but argument is of type 'u64 *' {aka 'long long unsigned int *'}
> >   309 | static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
> >       |                                                            ~~~~~~~~~~^~~~
> > cc1: some warnings being treated as errors
> > 
> > Caused by commit
> > 
> >   a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")
> > 
> > I have used the net-next tree from next-20211001 for today.  
> 
> I also had to use the next-20211001 version if the bpf-next tree (since
> it had been reset past the broken commit in the net-next tree).

And the bluetooth tree similarly.

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH net-next] ethernet: ehea: add missing cast

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (refs/heads/master):

On Mon,  4 Oct 2021 18:11:14 -0700 you wrote:
> We need to cast the pointer, unlike memcpy() eth_hw_addr_set()
> does not take void *. The driver already casts &port->mac_addr
> to u8 * in other places.
> 
> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
> Fixes: a96d317fb1a3 ("ethernet: use eth_hw_addr_set()")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> 
> [...]

Here is the summary with links:
  - [net-next] ethernet: ehea: add missing cast
    https://git.kernel.org/netdev/net-next/c/ceca777dabc6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html