From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE4EBC433FE for ; Tue, 5 Oct 2021 14:27:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C7900610EA for ; Tue, 5 Oct 2021 14:27:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235251AbhJEO25 (ORCPT ); Tue, 5 Oct 2021 10:28:57 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:10576 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235038AbhJEO24 (ORCPT ); Tue, 5 Oct 2021 10:28:56 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1633444026; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=7qAebyYS3/yHi3zj4WopwoEdiogpKvoME2WoVInf0ek=; b=crzjBBNKPPMFOfojAwOBwcTMH++uT7kT2RXRdYlcAWEfjX8FOIvEaa0tCuVOQpuptDPduNDS +YHF/gBjD1Jf8jpWCxhmLj/9UZPwASmFQb9jsB0Md3vFDOlrPLxuPPkHHDU5iuEDkMMbRkXO X7OIuJAKy73XbzQWPubxIq1TDU0= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJiZjI2MiIsICJuZXRkZXZAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 615c60acb8ab9916b3b707b1 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 05 Oct 2021 14:26:52 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id F3118C4360D; Tue, 5 Oct 2021 14:26:51 +0000 (UTC) Received: from tykki.adurom.net (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id A853CC4338F; Tue, 5 Oct 2021 14:26:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org A853CC4338F Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v3] ath10k: Don't always treat modem stop events as crashes From: Kalle Valo In-Reply-To: <20210922233341.182624-1-swboyd@chromium.org> References: <20210922233341.182624-1-swboyd@chromium.org> To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, Youghandhar Chintala , Abhishek Kumar , Steev Klimaszewski , Matthias Kaehlcke , Rakesh Pillai User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.7.3 Message-Id: <20211005142651.F3118C4360D@smtp.codeaurora.org> Date: Tue, 5 Oct 2021 14:26:51 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Stephen Boyd wrote: > When rebooting on sc7180 Trogdor devices I see the following crash from > the wifi driver. > > ath10k_snoc 18800000.wifi: firmware crashed! (guid 83493570-29a2-4e98-a83e-70048c47669c) > > This is because a modem stop event looks just like a firmware crash to > the driver, the qmi connection is closed in both cases. Use the qcom ssr > notifier block to stop treating the qmi connection close event as a > firmware crash signal when the modem hasn't actually crashed. See > ath10k_qmi_event_server_exit() for more details. > > This silences the crash message seen during every reboot. > > Fixes: 3f14b73c3843 ("ath10k: Enable MSA region dump support for WCN3990") > Cc: Youghandhar Chintala > Cc: Abhishek Kumar > Cc: Steev Klimaszewski > Cc: Matthias Kaehlcke > Cc: Rakesh Pillai > Signed-off-by: Stephen Boyd > Reviewed-by: Rakesh Pillai > Tested-By: Youghandhar Chintala > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. 747ff7d3d742 ath10k: Don't always treat modem stop events as crashes -- https://patchwork.kernel.org/project/linux-wireless/patch/20210922233341.182624-1-swboyd@chromium.org/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches