* strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26"
@ 2021-10-06 21:43 Chris Packham
2021-10-06 21:48 ` Dmitry V. Levin
0 siblings, 1 reply; 4+ messages in thread
From: Chris Packham @ 2021-10-06 21:43 UTC (permalink / raw)
To: Steffen Klassert, Herbert Xu, David S. Miller
Cc: netdev, linux-kernel@vger.kernel.org
Hi,
When compiling strace-5.14 (although it looks like the same problem
would exist with bleeding edge strace) with headers from the tip of
Linus's tree (5.15.0-rc4) I get the following error
strace: In file included from static_assert.h:11,
strace: from print_fields.h:12,
strace: from defs.h:1901,
strace: from netlink.c:10:
strace: xlat/nl_xfrm_types.h:162:1: error: static assertion failed:
"XFRM_MSG_MAPPING != 0x26"
strace: static_assert((XFRM_MSG_MAPPING) == (0x26), "XFRM_MSG_MAPPING
!= 0x26");
strace: ^~~~~~~~~~~~~
It looks like commit 2d151d39073a ("xfrm: Add possibility to set the
default to block if we have no policy") added some XFRM messages and the
numbers shifted. Is this considered an ABI breakage?
I'm not sure if this is a strace problem or a linux problem so I'm
reporting it in both places.
Thanks,
Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26"
2021-10-06 21:43 strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26" Chris Packham
@ 2021-10-06 21:48 ` Dmitry V. Levin
2021-10-06 21:51 ` Dmitry V. Levin
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry V. Levin @ 2021-10-06 21:48 UTC (permalink / raw)
To: Chris Packham
Cc: Eugene Syromyatnikov, Steffen Klassert, Herbert Xu,
David S. Miller, netdev, linux-kernel@vger.kernel.org
On Wed, Oct 06, 2021 at 09:43:11PM +0000, Chris Packham wrote:
> Hi,
>
> When compiling strace-5.14 (although it looks like the same problem
> would exist with bleeding edge strace) with headers from the tip of
> Linus's tree (5.15.0-rc4) I get the following error
>
> strace: In file included from static_assert.h:11,
> strace: from print_fields.h:12,
> strace: from defs.h:1901,
> strace: from netlink.c:10:
> strace: xlat/nl_xfrm_types.h:162:1: error: static assertion failed:
> "XFRM_MSG_MAPPING != 0x26"
> strace: static_assert((XFRM_MSG_MAPPING) == (0x26), "XFRM_MSG_MAPPING
> != 0x26");
> strace: ^~~~~~~~~~~~~
>
> It looks like commit 2d151d39073a ("xfrm: Add possibility to set the
> default to block if we have no policy") added some XFRM messages and the
> numbers shifted. Is this considered an ABI breakage?
>
> I'm not sure if this is a strace problem or a linux problem so I'm
> reporting it in both places.
Yes, this is already covered by
https://lore.kernel.org/lkml/20210912122234.GA22469@asgard.redhat.com/T/#u
Thanks,
--
ldv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26"
2021-10-06 21:48 ` Dmitry V. Levin
@ 2021-10-06 21:51 ` Dmitry V. Levin
2021-10-07 5:57 ` Steffen Klassert
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry V. Levin @ 2021-10-06 21:51 UTC (permalink / raw)
To: Chris Packham, Eugene Syromyatnikov, Steffen Klassert, Herbert Xu,
David S. Miller, netdev, linux-kernel@vger.kernel.org
On Thu, Oct 07, 2021 at 12:48:16AM +0300, Dmitry V. Levin wrote:
> On Wed, Oct 06, 2021 at 09:43:11PM +0000, Chris Packham wrote:
> > Hi,
> >
> > When compiling strace-5.14 (although it looks like the same problem
> > would exist with bleeding edge strace) with headers from the tip of
> > Linus's tree (5.15.0-rc4) I get the following error
> >
> > strace: In file included from static_assert.h:11,
> > strace: from print_fields.h:12,
> > strace: from defs.h:1901,
> > strace: from netlink.c:10:
> > strace: xlat/nl_xfrm_types.h:162:1: error: static assertion failed:
> > "XFRM_MSG_MAPPING != 0x26"
> > strace: static_assert((XFRM_MSG_MAPPING) == (0x26), "XFRM_MSG_MAPPING
> > != 0x26");
> > strace: ^~~~~~~~~~~~~
> >
> > It looks like commit 2d151d39073a ("xfrm: Add possibility to set the
> > default to block if we have no policy") added some XFRM messages and the
> > numbers shifted. Is this considered an ABI breakage?
> >
> > I'm not sure if this is a strace problem or a linux problem so I'm
> > reporting it in both places.
>
> Yes, this is already covered by
> https://lore.kernel.org/lkml/20210912122234.GA22469@asgard.redhat.com/T/#u
>
> Thanks,
I wonder, why the fix hasn't been merged yet, though.
--
ldv
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26"
2021-10-06 21:51 ` Dmitry V. Levin
@ 2021-10-07 5:57 ` Steffen Klassert
0 siblings, 0 replies; 4+ messages in thread
From: Steffen Klassert @ 2021-10-07 5:57 UTC (permalink / raw)
To: Dmitry V. Levin
Cc: Chris Packham, Eugene Syromyatnikov, Herbert Xu, David S. Miller,
netdev, linux-kernel@vger.kernel.org
On Thu, Oct 07, 2021 at 12:51:24AM +0300, Dmitry V. Levin wrote:
> On Thu, Oct 07, 2021 at 12:48:16AM +0300, Dmitry V. Levin wrote:
> > On Wed, Oct 06, 2021 at 09:43:11PM +0000, Chris Packham wrote:
> > > Hi,
> > >
> > > When compiling strace-5.14 (although it looks like the same problem
> > > would exist with bleeding edge strace) with headers from the tip of
> > > Linus's tree (5.15.0-rc4) I get the following error
> > >
> > > strace: In file included from static_assert.h:11,
> > > strace: from print_fields.h:12,
> > > strace: from defs.h:1901,
> > > strace: from netlink.c:10:
> > > strace: xlat/nl_xfrm_types.h:162:1: error: static assertion failed:
> > > "XFRM_MSG_MAPPING != 0x26"
> > > strace: static_assert((XFRM_MSG_MAPPING) == (0x26), "XFRM_MSG_MAPPING
> > > != 0x26");
> > > strace: ^~~~~~~~~~~~~
> > >
> > > It looks like commit 2d151d39073a ("xfrm: Add possibility to set the
> > > default to block if we have no policy") added some XFRM messages and the
> > > numbers shifted. Is this considered an ABI breakage?
> > >
> > > I'm not sure if this is a strace problem or a linux problem so I'm
> > > reporting it in both places.
> >
> > Yes, this is already covered by
> > https://lore.kernel.org/lkml/20210912122234.GA22469@asgard.redhat.com/T/#u
> >
> > Thanks,
>
> I wonder, why the fix hasn't been merged yet, though.
That was due to a delay on my side. I've just sent a pull request
with the fix included.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-10-07 5:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-06 21:43 strace build error static assertion failed: "XFRM_MSG_MAPPING != 0x26" Chris Packham
2021-10-06 21:48 ` Dmitry V. Levin
2021-10-06 21:51 ` Dmitry V. Levin
2021-10-07 5:57 ` Steffen Klassert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).