From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Claudiu Manoil <claudiu.manoil@nxp.com>
Subject: Re: [PATCH net-next v2 1/2] net: enetc: declare NETIF_F_HW_CSUM and do it in software
Date: Thu, 7 Oct 2021 20:41:35 +0000 [thread overview]
Message-ID: <20211007204134.y5ppnce64top4nm4@skbuf> (raw)
In-Reply-To: <20211007153043.2675008-2-ioana.ciornei@nxp.com>
On Thu, Oct 07, 2021 at 06:30:42PM +0300, Ioana Ciornei wrote:
> This is just a preparation patch for software TSO in the enetc driver.
> Unfortunately, ENETC does not support Tx checksum offload which would
> normally render TSO, even software, impossible.
>
> Declare NETIF_F_HW_CSUM as part of the feature set and do it at driver
> level using skb_csum_hwoffload_help() so that we can move forward and
The comment is still referencing the other function you were calling in v1.
Anyway, not a big deal, in the end everything ends up in skb_checksum_help().
> also add support for TSO in the next patch.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
> ---
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
next prev parent reply other threads:[~2021-10-07 20:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 15:30 [PATCH net-next v2 0/2] net: enetc: add support for software TSO Ioana Ciornei
2021-10-07 15:30 ` [PATCH net-next v2 1/2] net: enetc: declare NETIF_F_HW_CSUM and do it in software Ioana Ciornei
2021-10-07 20:41 ` Vladimir Oltean [this message]
2021-10-07 15:30 ` [PATCH net-next v2 2/2] net: enetc: add support for software TSO Ioana Ciornei
2021-10-07 18:14 ` Claudiu Manoil
2021-10-07 22:10 ` Vladimir Oltean
2021-10-08 16:30 ` [PATCH net-next v2 0/2] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211007204134.y5ppnce64top4nm4@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).