netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeroen de Borst <jeroendb@google.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org,
	Catherine Sullivan <csully@google.com>,
	Jeroen de Borst <jeroendb@google.com>
Subject: [PATCH net-next v2 7/7] gve: Track RX buffer allocation failures
Date: Mon, 11 Oct 2021 08:36:50 -0700	[thread overview]
Message-ID: <20211011153650.1982904-8-jeroendb@google.com> (raw)
In-Reply-To: <20211011153650.1982904-1-jeroendb@google.com>

From: Catherine Sullivan <csully@google.com>

The rx_buf_alloc_fail counter wasn't getting updated.

Fixes: 433e274b8f7b0 ("gve: Add stats for gve.")
Signed-off-by: Catherine Sullivan <csully@google.com>
Signed-off-by: Jeroen de Borst <jeroendb@google.com>
---
 drivers/net/ethernet/google/gve/gve_rx.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/google/gve/gve_rx.c b/drivers/net/ethernet/google/gve/gve_rx.c
index 98ba981cd534..95bc4d8a1811 100644
--- a/drivers/net/ethernet/google/gve/gve_rx.c
+++ b/drivers/net/ethernet/google/gve/gve_rx.c
@@ -532,8 +532,13 @@ static bool gve_rx_refill_buffers(struct gve_priv *priv, struct gve_rx_ring *rx)
 
 				gve_rx_free_buffer(dev, page_info, data_slot);
 				page_info->page = NULL;
-				if (gve_rx_alloc_buffer(priv, dev, page_info, data_slot))
+				if (gve_rx_alloc_buffer(priv, dev, page_info,
+							data_slot)) {
+					u64_stats_update_begin(&rx->statss);
+					rx->rx_buf_alloc_fail++;
+					u64_stats_update_end(&rx->statss);
 					break;
+				}
 			}
 		}
 		fill_cnt++;
-- 
2.33.0.882.g93a45727a2-goog

v2: Unchanged

  parent reply	other threads:[~2021-10-11 15:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 15:36 [PATCH net-next v2 0/7] gve: minor code and performance improvements Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 1/7] gve: Switch to use napi_complete_done Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 2/7] gve: Add rx buffer pagecnt bias Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 3/7] gve: Do lazy cleanup in TX path Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 4/7] gve: Recover from queue stall due to missed IRQ Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 5/7] gve: Add netif_set_xps_queue call Jeroen de Borst
2021-10-11 15:36 ` [PATCH net-next v2 6/7] gve: Allow pageflips on larger pages Jeroen de Borst
2021-10-11 15:36 ` Jeroen de Borst [this message]
2021-10-11 22:30 ` [PATCH net-next v2 0/7] gve: minor code and performance improvements patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011153650.1982904-8-jeroendb@google.com \
    --to=jeroendb@google.com \
    --cc=csully@google.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).