Re: [PATCH net] net: dsa: fix spurious error message when unoffloaded port leaves bridge

Vladimir Oltean
2021-10-12T11:36:35Z

On Tue, Oct 12, 2021 at 01:27:31PM +0200, Alvin Šipraga wrote:
> From: Alvin Šipraga <alsi@bang-olufsen.dk>
>
> Flip the sign of a return value check, thereby suppressing the following
> spurious error:
>
> port 2 failed to notify DSA_NOTIFIER_BRIDGE_LEAVE: -EOPNOTSUPP
>
> ... which is emitted when removing an unoffloaded DSA switch port from a
> bridge.
>
> Fixes: d371b7c92d19 ("net: dsa: Unset vlan_filtering when ports leave the bridge")
> Signed-off-by: Alvin Šipraga <alsi@bang-olufsen.dk>
> ---
> net/dsa/switch.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/dsa/switch.c b/net/dsa/switch.c
> index 1c797ec8e2c2..6466d0539af9 100644
> --- a/net/dsa/switch.c
> +++ b/net/dsa/switch.c
> @@ -168,7 +168,7 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
> if (extack._msg)
> dev_err(ds->dev, "port %d: %s\n", info->port,
> extack._msg);
> - if (err && err != EOPNOTSUPP)
> + if (err && err != -EOPNOTSUPP)
> return err;
> }
>
> --
> 2.32.0
>

Ouch, good catch.

Reviewed-by: Vladimir Oltean <olteanv@gmail.com>