From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 5318FC433EF
	for <netdev@archiver.kernel.org>; Thu, 14 Oct 2021 11:17:30 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 28624610D0
	for <netdev@archiver.kernel.org>; Thu, 14 Oct 2021 11:17:30 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230202AbhJNLTd (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 14 Oct 2021 07:19:33 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52246 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229513AbhJNLTc (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 14 Oct 2021 07:19:32 -0400
Received: from orbyte.nwl.cc (orbyte.nwl.cc [IPv6:2001:41d0:e:133a::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C80E2C061570
        for <netdev@vger.kernel.org>; Thu, 14 Oct 2021 04:17:27 -0700 (PDT)
Received: from n0-1 by orbyte.nwl.cc with local (Exim 4.94.2)
        (envelope-from <n0-1@orbyte.nwl.cc>)
        id 1mayjl-0007Rb-5o; Thu, 14 Oct 2021 13:17:25 +0200
Date:   Thu, 14 Oct 2021 13:17:25 +0200
From:   Phil Sutter <phil@nwl.cc>
To:     Andrea Claudi <aclaudi@redhat.com>
Cc:     netdev@vger.kernel.org, stephen@networkplumber.org,
        dsahern@gmail.com, bluca@debian.org, haliu@redhat.com
Subject: Re: [PATCH iproute2 v5 7/7] configure: add the --libdir option
Message-ID: <20211014111725.GK1668@orbyte.nwl.cc>
Mail-Followup-To: Phil Sutter <phil@nwl.cc>,
        Andrea Claudi <aclaudi@redhat.com>, netdev@vger.kernel.org,
        stephen@networkplumber.org, dsahern@gmail.com, bluca@debian.org,
        haliu@redhat.com
References: <cover.1634199240.git.aclaudi@redhat.com>
 <62f6968cc2647685a0ef8074687ecf12c8c1f3c0.1634199240.git.aclaudi@redhat.com>
 <20211014101053.GJ1668@orbyte.nwl.cc>
 <YWgOUedjAR+sAtcG@renaissance-vector>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YWgOUedjAR+sAtcG@renaissance-vector>
Sender:  <n0-1@orbyte.nwl.cc>
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, Oct 14, 2021 at 01:02:41PM +0200, Andrea Claudi wrote:
> On Thu, Oct 14, 2021 at 12:10:53PM +0200, Phil Sutter wrote:
> > Hi Andrea,
> > 
> > On Thu, Oct 14, 2021 at 10:50:55AM +0200, Andrea Claudi wrote:
> > [...]
> > > diff --git a/Makefile b/Makefile
> > > index 5eddd504..f6214534 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1,6 +1,8 @@
> > >  # SPDX-License-Identifier: GPL-2.0
> > >  # Top level Makefile for iproute2
> > >  
> > > +-include config.mk
> > > +
> > 
> > Assuming config.mk may be missing (as dash-prefix is used).
> > 
> > >  ifeq ("$(origin V)", "command line")
> > >  VERBOSE = $(V)
> > >  endif
> > > @@ -13,7 +15,6 @@ MAKEFLAGS += --no-print-directory
> > >  endif
> > >  
> > >  PREFIX?=/usr
> > > -LIBDIR?=$(PREFIX)/lib
> > 
> > Dropping this leads to trouble if config.mk is missing or didn't define
> > it. Can't you just leave it in place? Usually config.mk would override
> > it anyway, no?
> 
> config.mk may miss at the first make call, but the "all" target calls
> config.mk, which in turns re-generate it. Thus LIBDIR is defined when
> the target all executes.

Ah, I forgot the call to configure from make. So full series:

Acked-by: Phil Sutter <phil@nwl.cc>

Thanks, Phil