From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>
Subject: Re: ip_list_rcv() question
Date: Thu, 14 Oct 2021 10:42:31 -0400 [thread overview]
Message-ID: <20211014144231.GA11651@ICIPI.localdomain> (raw)
In-Reply-To: <4dddfda5-1c03-6386-e204-e21df07aabd1@gmail.com>
On Wed, Oct 13, 2021 at 05:17:51PM +0100, Edward Cree wrote:
> On 07/10/2021 13:14, Stephen Suryaputra wrote:
> > Under what condition that ip_list_rcv() would restart the sublist, i.e.
> > that the skb in the list is having different skb->dev?
>
> IIRC, something earlier in the call chain (possibly
> __netif_receive_skb_core()?) can change skb->dev to something other
> than the device that originally received the packet (orig_dev). I
> think it's if the packet gets handled/transformed by a software
> netdevice (maybe a VLAN device?).
> But really when I wrote ip_list_rcv() I just worked on the basis
> that "I don't know it can't change, so I shall assume it can".
I see now that vlan_do_receive() changes the skb->dev. It didn't occur
to me because __netif_receive_skb_list_core() has a similar logic for
dispatching sublists. But still the skb->dev could be different that
orig_dev.
Thanks.
prev parent reply other threads:[~2021-10-14 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 12:14 ip_list_rcv() question Stephen Suryaputra
2021-10-13 16:17 ` Edward Cree
2021-10-14 14:42 ` Stephen Suryaputra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211014144231.GA11651@ICIPI.localdomain \
--to=ssuryaextr@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox