From: Alex Williamson <alex.williamson@redhat.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: Jason Gunthorpe <jgg@nvidia.com>, <bhelgaas@google.com>,
<saeedm@nvidia.com>, <linux-pci@vger.kernel.org>,
<kvm@vger.kernel.org>, <netdev@vger.kernel.org>,
<kuba@kernel.org>, <leonro@nvidia.com>, <kwankhede@nvidia.com>,
<mgurtovoy@nvidia.com>, <maorg@nvidia.com>
Subject: Re: [PATCH V1 mlx5-next 13/13] vfio/mlx5: Trap device RESET and update state accordingly
Date: Fri, 15 Oct 2021 13:54:23 -0600 [thread overview]
Message-ID: <20211015135423.5f8db5d7.alex.williamson@redhat.com> (raw)
In-Reply-To: <cae3309e-4175-b134-c1f6-5ec02f352078@nvidia.com>
On Thu, 14 Oct 2021 12:18:30 +0300
Yishai Hadas <yishaih@nvidia.com> wrote:
> On 10/13/2021 9:06 PM, Jason Gunthorpe wrote:
> > On Wed, Oct 13, 2021 at 12:47:07PM +0300, Yishai Hadas wrote:
> >> Trap device RESET and update state accordingly, it's done by registering
> >> the matching callbacks.
> >>
> >> Signed-off-by: Yishai Hadas <yishaih@nvidia.com>
> >> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
> >> drivers/vfio/pci/mlx5/main.c | 17 ++++++++++++++++-
> >> 1 file changed, 16 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/vfio/pci/mlx5/main.c b/drivers/vfio/pci/mlx5/main.c
> >> index e36302b444a6..8fe44ed13552 100644
> >> +++ b/drivers/vfio/pci/mlx5/main.c
> >> @@ -613,6 +613,19 @@ static const struct vfio_device_ops mlx5vf_pci_ops = {
> >> .match = vfio_pci_core_match,
> >> };
> >>
> >> +static void mlx5vf_reset_done(struct vfio_pci_core_device *core_vdev)
> >> +{
> >> + struct mlx5vf_pci_core_device *mvdev = container_of(
> >> + core_vdev, struct mlx5vf_pci_core_device,
> >> + core_device);
> >> +
> >> + mvdev->vmig.vfio_dev_state = VFIO_DEVICE_STATE_RUNNING;
> > This should hold the state mutex too
> >
> Thanks Jason, I'll add as part of V2.
>
> Alex,
>
> Any feedback from your side before that we'll send V2 ?
>
> We already got ACK for the PCI patches, there are some minor changes to
> be done so far.
Provided. Thanks,
Alex
prev parent reply other threads:[~2021-10-15 19:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 9:46 [PATCH V1 mlx5-next 00/13] Add mlx5 live migration driver Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 01/13] PCI/IOV: Provide internal VF index Yishai Hadas
2021-10-13 18:14 ` Bjorn Helgaas
2021-10-14 9:08 ` Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 02/13] net/mlx5: Reuse exported virtfn index function call Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 03/13] net/mlx5: Disable SRIOV before PF removal Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 04/13] PCI/IOV: Allow SRIOV VF drivers to reach the drvdata of a PF Yishai Hadas
2021-10-13 18:27 ` Bjorn Helgaas
2021-10-14 22:11 ` Alex Williamson
2021-10-17 13:43 ` Yishai Hadas
2021-10-13 9:46 ` [PATCH V1 mlx5-next 05/13] net/mlx5: Expose APIs to get/put the mlx5 core device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 06/13] vdpa/mlx5: Use mlx5_vf_get_core_dev() to get PF device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 07/13] vfio: Add 'invalid' state definitions Yishai Hadas
2021-10-15 16:38 ` Alex Williamson
2021-10-17 14:07 ` Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 08/13] vfio/pci_core: Make the region->release() function optional Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 09/13] net/mlx5: Introduce migration bits and structures Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 10/13] vfio/mlx5: Expose migration commands over mlx5 device Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 11/13] vfio/mlx5: Implement vfio_pci driver for mlx5 devices Yishai Hadas
2021-10-15 19:48 ` Alex Williamson
2021-10-15 19:59 ` Jason Gunthorpe
2021-10-15 20:12 ` Alex Williamson
2021-10-15 20:16 ` Jason Gunthorpe
2021-10-15 20:59 ` Alex Williamson
2021-10-17 14:03 ` Yishai Hadas
2021-10-18 11:51 ` Jason Gunthorpe
2021-10-18 13:26 ` Yishai Hadas
2021-10-18 13:42 ` Alex Williamson
2021-10-18 13:46 ` Yishai Hadas
2021-10-19 9:59 ` Shameerali Kolothum Thodi
2021-10-19 10:30 ` Yishai Hadas
2021-10-19 11:26 ` Shameerali Kolothum Thodi
2021-10-19 11:24 ` Jason Gunthorpe
2021-10-13 9:47 ` [PATCH V1 mlx5-next 12/13] vfio/pci: Add infrastructure to let vfio_pci_core drivers trap device RESET Yishai Hadas
2021-10-15 19:52 ` Alex Williamson
2021-10-15 20:03 ` Jason Gunthorpe
2021-10-15 21:12 ` Alex Williamson
2021-10-17 14:29 ` Yishai Hadas
2021-10-18 12:02 ` Jason Gunthorpe
2021-10-18 13:41 ` Yishai Hadas
2021-10-13 9:47 ` [PATCH V1 mlx5-next 13/13] vfio/mlx5: Trap device RESET and update state accordingly Yishai Hadas
2021-10-13 18:06 ` Jason Gunthorpe
2021-10-14 9:18 ` Yishai Hadas
2021-10-15 19:54 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211015135423.5f8db5d7.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=bhelgaas@google.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-pci@vger.kernel.org \
--cc=maorg@nvidia.com \
--cc=mgurtovoy@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).