[PATCH net-next 1/2] net: macvtap: fix template string argument of device_create() call

[PATCH net-next 1/2] net: macvtap: fix template string argument of device_create() call

[Jεan Sacren]

From: Jean Sacren <sakiwit@gmail.com>

The last argument of device_create() call should be a template string.
The tap_name variable should be the argument to the string, but not the
argument of the call itself.  We should add the template string and turn
tap_name into its argument.

Signed-off-by: Jean Sacren <sakiwit@gmail.com>
---
 drivers/net/macvtap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 694e2f5dbbe5..6b12902a803f 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -169,7 +169,7 @@ static int macvtap_device_event(struct notifier_block *unused,
 
 		devt = MKDEV(MAJOR(macvtap_major), vlantap->tap.minor);
 		classdev = device_create(&macvtap_class, &dev->dev, devt,
-					 dev, tap_name);
+					 dev, "%s", tap_name);
 		if (IS_ERR(classdev)) {
 			tap_free_minor(macvtap_major, &vlantap->tap);
 			return notifier_from_errno(PTR_ERR(classdev));

Re: [PATCH net-next 1/2] net: macvtap: fix template string argument of device_create() call

[patchwork-bot+netdevbpf]

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 15 Oct 2021 23:41:34 -0600 you wrote:
> From: Jean Sacren <sakiwit@gmail.com>
> 
> The last argument of device_create() call should be a template string.
> The tap_name variable should be the argument to the string, but not the
> argument of the call itself.  We should add the template string and turn
> tap_name into its argument.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] net: macvtap: fix template string argument of device_create() call
    https://git.kernel.org/netdev/net-next/c/1c5b5b3f0eab
  - [net-next,2/2] net: ipvtap: fix template string argument of device_create() call
    https://git.kernel.org/netdev/net-next/c/a07a296bba9d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html