netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>, netdev@vger.kernel.org
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
	Taras Chornyi <taras.chornyi@plvision.eu>,
	Mickey Rachamim <mickeyr@marvell.com>,
	Serhiy Pshyk <serhiy.pshyk@plvision.eu>,
	Andrew Lunn <andrew@lunn.ch>,
	Volodymyr Mytnyk <vmytnyk@marvell.com>,
	Vadym Kochan <vkochan@marvell.com>,
	Yevhen Orlov <yevhen.orlov@plvision.eu>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: marvell: prestera: add firmware v4.0 support
Date: Sat, 16 Oct 2021 11:51:11 +0800	[thread overview]
Message-ID: <202110161121.0cbwJ6rU-lkp@intel.com> (raw)
In-Reply-To: <1634309793-23816-1-git-send-email-volodymyr.mytnyk@plvision.eu>

[-- Attachment #1: Type: text/plain, Size: 3307 bytes --]

Hi Volodymyr,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211015-225941
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 40088915f547b52635f022c1e1e18df65ae3153a
config: arm-randconfig-r024-20211015 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a49f5386ce6b091da66ea7c3a1d9a588d53becf7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        # https://github.com/0day-ci/linux/commit/af0e1a7d7646e639d30d05831aa0a5c4a1b22ff5
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Volodymyr-Mytnyk/net-marvell-prestera-add-firmware-v4-0-support/20211015-225941
        git checkout af0e1a7d7646e639d30d05831aa0a5c4a1b22ff5
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/marvell/prestera/prestera_hw.c:786:5: warning: no previous prototype for function 'prestera_hw_port_state_set' [-Wmissing-prototypes]
   int prestera_hw_port_state_set(const struct prestera_port *port,
       ^
   drivers/net/ethernet/marvell/prestera/prestera_hw.c:786:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int prestera_hw_port_state_set(const struct prestera_port *port,
   ^
   static 
   1 warning generated.


vim +/prestera_hw_port_state_set +786 drivers/net/ethernet/marvell/prestera/prestera_hw.c

e1189d9a5fbec8 Vadym Kochan 2020-09-16  785  
501ef3066c89d7 Vadym Kochan 2020-09-16 @786  int prestera_hw_port_state_set(const struct prestera_port *port,
501ef3066c89d7 Vadym Kochan 2020-09-16  787  			       bool admin_state)
501ef3066c89d7 Vadym Kochan 2020-09-16  788  {
501ef3066c89d7 Vadym Kochan 2020-09-16  789  	struct prestera_msg_port_attr_req req = {
501ef3066c89d7 Vadym Kochan 2020-09-16  790  		.attr = PRESTERA_CMD_PORT_ATTR_ADMIN_STATE,
501ef3066c89d7 Vadym Kochan 2020-09-16  791  		.port = port->hw_id,
501ef3066c89d7 Vadym Kochan 2020-09-16  792  		.dev = port->dev_id,
501ef3066c89d7 Vadym Kochan 2020-09-16  793  		.param = {
501ef3066c89d7 Vadym Kochan 2020-09-16  794  			.admin_state = admin_state,
501ef3066c89d7 Vadym Kochan 2020-09-16  795  		}
501ef3066c89d7 Vadym Kochan 2020-09-16  796  	};
501ef3066c89d7 Vadym Kochan 2020-09-16  797  
501ef3066c89d7 Vadym Kochan 2020-09-16  798  	return prestera_cmd(port->sw, PRESTERA_CMD_TYPE_PORT_ATTR_SET,
501ef3066c89d7 Vadym Kochan 2020-09-16  799  			    &req.cmd, sizeof(req));
501ef3066c89d7 Vadym Kochan 2020-09-16  800  }
501ef3066c89d7 Vadym Kochan 2020-09-16  801  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 38416 bytes --]

      parent reply	other threads:[~2021-10-16  3:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-15 14:56 [PATCH net-next] net: marvell: prestera: add firmware v4.0 support Volodymyr Mytnyk
2021-10-15 21:19 ` Jakub Kicinski
2021-10-19  5:59   ` Volodymyr Mytnyk [C]
2021-10-16  3:51 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202110161121.0cbwJ6rU-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrew@lunn.ch \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mickeyr@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=serhiy.pshyk@plvision.eu \
    --cc=taras.chornyi@plvision.eu \
    --cc=vkochan@marvell.com \
    --cc=vmytnyk@marvell.com \
    --cc=volodymyr.mytnyk@plvision.eu \
    --cc=yevhen.orlov@plvision.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).