From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, olteanv@gmail.com, andrew@lunn.ch,
idosch@idosch.org, f.fainelli@gmail.com, snelson@pensando.io,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next 6/6] ethernet: sparx5: use eth_hw_addr_gen()
Date: Mon, 18 Oct 2021 14:10:07 -0700 [thread overview]
Message-ID: <20211018211007.1185777-7-kuba@kernel.org> (raw)
In-Reply-To: <20211018211007.1185777-1-kuba@kernel.org>
Commit 406f42fa0d3c ("net-next: When a bond have a massive amount
of VLANs...") introduced a rbtree for faster Ethernet address look
up. To maintain netdev->dev_addr in this tree we need to make all
the writes to it got through appropriate helpers.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c b/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
index b21ebaa32d7e..e042f117dc7a 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_netdev.c
@@ -200,7 +200,6 @@ struct net_device *sparx5_create_netdev(struct sparx5 *sparx5, u32 portno)
{
struct sparx5_port *spx5_port;
struct net_device *ndev;
- u64 val;
ndev = devm_alloc_etherdev(sparx5->dev, sizeof(struct sparx5_port));
if (!ndev)
@@ -216,8 +215,7 @@ struct net_device *sparx5_create_netdev(struct sparx5 *sparx5, u32 portno)
ndev->netdev_ops = &sparx5_port_netdev_ops;
ndev->ethtool_ops = &sparx5_ethtool_ops;
- val = ether_addr_to_u64(sparx5->base_mac) + portno + 1;
- u64_to_ether_addr(val, ndev->dev_addr);
+ eth_hw_addr_gen(ndev, sparx5->base_mac, portno + 1);
return ndev;
}
--
2.31.1
next prev parent reply other threads:[~2021-10-18 21:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 21:10 [PATCH net-next 0/6] ethernet: add eth_hw_addr_gen() for switches Jakub Kicinski
2021-10-18 21:10 ` [PATCH net-next 1/6] ethernet: add a helper for assigning port addresses Jakub Kicinski
2021-10-18 21:37 ` Vladimir Oltean
2021-10-18 21:54 ` Shannon Nelson
2021-10-19 6:11 ` Ido Schimmel
2021-10-18 21:10 ` [PATCH net-next 2/6] ethernet: ocelot: use eth_hw_addr_gen() Jakub Kicinski
2021-10-18 21:33 ` Vladimir Oltean
2021-10-18 21:10 ` [PATCH net-next 3/6] ethernet: prestera: " Jakub Kicinski
2021-10-18 21:10 ` [PATCH net-next 4/6] ethernet: fec: " Jakub Kicinski
2021-10-18 23:19 ` Vladimir Oltean
2021-10-18 21:10 ` [PATCH net-next 5/6] ethernet: mlxsw: " Jakub Kicinski
2021-10-19 6:12 ` Ido Schimmel
2021-10-18 21:10 ` Jakub Kicinski [this message]
2021-10-19 11:50 ` [PATCH net-next 0/6] ethernet: add eth_hw_addr_gen() for switches patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211018211007.1185777-7-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@idosch.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=snelson@pensando.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).