From: kernel test robot <lkp@intel.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
mhi@lists.linux.dev
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
loic.poulain@linaro.org, hemantk@codeaurora.org,
bbhatt@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: Add mhi_prepare_for_transfer_autoqueue API for DL auto queue
Date: Wed, 20 Oct 2021 02:02:28 +0800 [thread overview]
Message-ID: <202110200258.IZNHNVsq-lkp@intel.com> (raw)
In-Reply-To: <20211019134451.174318-1-manivannan.sadhasivam@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 3130 bytes --]
Hi Manivannan,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.15-rc6 next-20211019]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/bus-mhi-Add-mhi_prepare_for_transfer_autoqueue-API-for-DL-auto-queue/20211019-221447
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 519d81956ee277b4419c723adfb154603c2565ba
config: hexagon-randconfig-r041-20211019 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project b37efed957ed0a0193d80020aefd55cb587dfc1f)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/434ab9e12f5e85c6d84c1a0524d850559b058291
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Manivannan-Sadhasivam/bus-mhi-Add-mhi_prepare_for_transfer_autoqueue-API-for-DL-auto-queue/20211019-221447
git checkout 434ab9e12f5e85c6d84c1a0524d850559b058291
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=hexagon
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/bus/mhi/core/main.c:1615:5: warning: no previous prototype for function '__mhi_prepare_for_transfer' [-Wmissing-prototypes]
int __mhi_prepare_for_transfer(struct mhi_device *mhi_dev, unsigned int flags)
^
drivers/bus/mhi/core/main.c:1615:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
int __mhi_prepare_for_transfer(struct mhi_device *mhi_dev, unsigned int flags)
^
static
1 warning generated.
vim +/__mhi_prepare_for_transfer +1615 drivers/bus/mhi/core/main.c
1614
> 1615 int __mhi_prepare_for_transfer(struct mhi_device *mhi_dev, unsigned int flags)
1616 {
1617 int ret, dir;
1618 struct mhi_controller *mhi_cntrl = mhi_dev->mhi_cntrl;
1619 struct mhi_chan *mhi_chan;
1620
1621 for (dir = 0; dir < 2; dir++) {
1622 mhi_chan = dir ? mhi_dev->dl_chan : mhi_dev->ul_chan;
1623 if (!mhi_chan)
1624 continue;
1625
1626 ret = mhi_prepare_channel(mhi_cntrl, mhi_chan, flags);
1627 if (ret)
1628 goto error_open_chan;
1629 }
1630
1631 return 0;
1632
1633 error_open_chan:
1634 for (--dir; dir >= 0; dir--) {
1635 mhi_chan = dir ? mhi_dev->dl_chan : mhi_dev->ul_chan;
1636 if (!mhi_chan)
1637 continue;
1638
1639 mhi_unprepare_channel(mhi_cntrl, mhi_chan);
1640 }
1641
1642 return ret;
1643 }
1644
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29177 bytes --]
prev parent reply other threads:[~2021-10-19 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 13:44 [PATCH] bus: mhi: Add mhi_prepare_for_transfer_autoqueue API for DL auto queue Manivannan Sadhasivam
2021-10-19 14:49 ` Jakub Kicinski
2021-10-19 16:00 ` Greg KH
2021-10-19 16:29 ` Manivannan Sadhasivam
2021-10-19 18:02 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110200258.IZNHNVsq-lkp@intel.com \
--to=lkp@intel.com \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).