From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: Antonio Quartulli <a@unstable.cc>
Cc: netdev@vger.kernel.org
Subject: Re: Sysctl addr_gen_mode does not control tunnel link-local addr
Date: Wed, 20 Oct 2021 09:50:18 -0400 [thread overview]
Message-ID: <20211020135018.GA21437@ICIPI.localdomain> (raw)
In-Reply-To: <cee7948d-a637-ca07-6788-61500672f8cf@unstable.cc>
On Wed, Oct 20, 2021 at 02:59:01PM +0200, Antonio Quartulli wrote:
> For sure, supporting IN6_ADDR_GEN_MODE_NONE is a low hanging fruit and
> should be implemented.
>
Thanks for reaffirming this!
> Other than my nitpick above, I'd suggest applying the same change to the
> GRE code path, as the behavior should be the same.
> Moreover, do you think that addrconf_add_mroute() should not be executed
> in this case? Otherwise you could simply add your new code into
> add_v4_addrs().
Initially I was thinking that why there is a need to call
addrconf_add_mroute() given the link-local addr hasn't been set. On a
second look, yes, the conditional is better be in add_v4_addrs(). It
will take care of GRE as well.
I'll put a formal patch.
Thanks!
prev parent reply other threads:[~2021-10-20 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 1:30 Sysctl addr_gen_mode does not control tunnel link-local addr Stephen Suryaputra
2021-10-20 12:59 ` Antonio Quartulli
2021-10-20 13:50 ` Stephen Suryaputra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211020135018.GA21437@ICIPI.localdomain \
--to=ssuryaextr@gmail.com \
--cc=a@unstable.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox