From: Stephen Hemminger <stephen@networkplumber.org>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: David Ahern <dsahern@gmail.com>,
netdev@vger.kernel.org, antony.antony@secunet.com,
steffen.klassert@secunet.com
Subject: Re: [PATCH iproute2 v2] xfrm: enable to manage default policies
Date: Thu, 21 Oct 2021 15:25:26 -0700 [thread overview]
Message-ID: <20211021152526.7bda8a8d@hermes.local> (raw)
In-Reply-To: <9acfb0e5-872d-e527-9feb-6e9f5cf2f447@6wind.com>
On Thu, 21 Oct 2021 23:23:01 +0200
Nicolas Dichtel <nicolas.dichtel@6wind.com> wrote:
> Le 21/10/2021 à 16:55, David Ahern a écrit :
> > On 10/18/21 2:30 AM, Nicolas Dichtel wrote:
> >> diff --git a/include/uapi/linux/xfrm.h b/include/uapi/linux/xfrm.h
> >> index ecd06396eb16..378b4092f26a 100644
> >> --- a/include/uapi/linux/xfrm.h
> >> +++ b/include/uapi/linux/xfrm.h
> >> @@ -213,13 +213,13 @@ enum {
> >> XFRM_MSG_GETSPDINFO,
> >> #define XFRM_MSG_GETSPDINFO XFRM_MSG_GETSPDINFO
> >>
> >> + XFRM_MSG_MAPPING,
> >> +#define XFRM_MSG_MAPPING XFRM_MSG_MAPPING
> >> +
> >> XFRM_MSG_SETDEFAULT,
> >> #define XFRM_MSG_SETDEFAULT XFRM_MSG_SETDEFAULT
> >> XFRM_MSG_GETDEFAULT,
> >> #define XFRM_MSG_GETDEFAULT XFRM_MSG_GETDEFAULT
> >> -
> >> - XFRM_MSG_MAPPING,
> >> -#define XFRM_MSG_MAPPING XFRM_MSG_MAPPING
> >> __XFRM_MSG_MAX
> >> };
> >> #define XFRM_MSG_MAX (__XFRM_MSG_MAX - 1)
> >> @@ -514,9 +514,12 @@ struct xfrm_user_offload {
> >> #define XFRM_OFFLOAD_INBOUND 2
> >>
> >> struct xfrm_userpolicy_default {
> >> -#define XFRM_USERPOLICY_DIRMASK_MAX (sizeof(__u8) * 8)
> >> - __u8 dirmask;
> >> - __u8 action;
> >> +#define XFRM_USERPOLICY_UNSPEC 0
> >> +#define XFRM_USERPOLICY_BLOCK 1
> >> +#define XFRM_USERPOLICY_ACCEPT 2
> >> + __u8 in;
> >> + __u8 fwd;
> >> + __u8 out;
> >> };
> >>
> >> /* backwards compatibility for userspace */
> >
> > that is already updated in iproute2-next.
> But this is needed for the iproute2 also. These will be in the linux v5.15 release.
Yes the header is already in iproute2 just not the code to use it.
PS: Need a volunteer to update ip xfrm to print in JSON like the
rest of ip sub commands.
next prev parent reply other threads:[~2021-10-21 22:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 6:13 [PATCH iproute2] xfrm: enable to manage default policies Nicolas Dichtel
2021-10-18 8:30 ` [PATCH iproute2 v2] " Nicolas Dichtel
2021-10-21 14:55 ` David Ahern
2021-10-21 21:23 ` Nicolas Dichtel
2021-10-21 22:10 ` David Ahern
2021-10-22 7:52 ` Nicolas Dichtel
2021-10-21 22:25 ` Stephen Hemminger [this message]
2021-10-25 8:17 ` [PATCH iproute2-next " Nicolas Dichtel
2021-10-28 15:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021152526.7bda8a8d@hermes.local \
--to=stephen@networkplumber.org \
--cc=antony.antony@secunet.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).