From: Vladimir Oltean <olteanv@gmail.com>
To: Julian Wiedmann <jwi@linux.ibm.com>
Cc: David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-netdev <netdev@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Karsten Graul <kgraul@linux.ibm.com>
Subject: Re: [PATCH net-next 6/9] s390/qeth: fix various format strings
Date: Mon, 25 Oct 2021 16:22:29 +0300 [thread overview]
Message-ID: <20211025132229.4opytunnnqnhxzdf@skbuf> (raw)
In-Reply-To: <20211025095658.3527635-7-jwi@linux.ibm.com>
On Mon, Oct 25, 2021 at 11:56:55AM +0200, Julian Wiedmann wrote:
> From: Heiko Carstens <hca@linux.ibm.com>
>
> Various format strings don't match with types of parameters.
> Fix all of them.
>
> Acked-by: Julian Wiedmann <jwi@linux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
> ---
> drivers/s390/net/qeth_l2_main.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/s390/net/qeth_l2_main.c b/drivers/s390/net/qeth_l2_main.c
> index adba52da9cab..0347fc184786 100644
> --- a/drivers/s390/net/qeth_l2_main.c
> +++ b/drivers/s390/net/qeth_l2_main.c
> @@ -661,13 +661,13 @@ static void qeth_l2_dev2br_fdb_notify(struct qeth_card *card, u8 code,
> card->dev, &info.info, NULL);
> QETH_CARD_TEXT(card, 4, "andelmac");
> QETH_CARD_TEXT_(card, 4,
> - "mc%012lx", ether_addr_to_u64(ntfy_mac));
> + "mc%012llx", ether_addr_to_u64(ntfy_mac));
> } else {
> call_switchdev_notifiers(SWITCHDEV_FDB_ADD_TO_BRIDGE,
> card->dev, &info.info, NULL);
> QETH_CARD_TEXT(card, 4, "anaddmac");
> QETH_CARD_TEXT_(card, 4,
> - "mc%012lx", ether_addr_to_u64(ntfy_mac));
> + "mc%012llx", ether_addr_to_u64(ntfy_mac));
You can print MAC addresses using the "%pM" printf format specifier, and
the ntfy_mac as argument.
> }
> }
>
> @@ -765,8 +765,8 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
> int err = 0;
>
> kfree(br2dev_event_work);
> - QETH_CARD_TEXT_(card, 4, "b2dw%04x", event);
> - QETH_CARD_TEXT_(card, 4, "ma%012lx", ether_addr_to_u64(addr));
> + QETH_CARD_TEXT_(card, 4, "b2dw%04lx", event);
> + QETH_CARD_TEXT_(card, 4, "ma%012llx", ether_addr_to_u64(addr));
>
> rcu_read_lock();
> /* Verify preconditions are still valid: */
> @@ -795,7 +795,7 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
> if (err) {
> QETH_CARD_TEXT(card, 2, "b2derris");
> QETH_CARD_TEXT_(card, 2,
> - "err%02x%03d", event,
> + "err%02lx%03d", event,
> lowerdev->ifindex);
> }
> }
> @@ -813,7 +813,7 @@ static void qeth_l2_br2dev_worker(struct work_struct *work)
> break;
> }
> if (err)
> - QETH_CARD_TEXT_(card, 2, "b2derr%02x", event);
> + QETH_CARD_TEXT_(card, 2, "b2derr%02lx", event);
> }
>
> unlock:
> @@ -878,7 +878,7 @@ static int qeth_l2_switchdev_event(struct notifier_block *unused,
> while (lowerdev) {
> if (qeth_l2_must_learn(lowerdev, dstdev)) {
> card = lowerdev->ml_priv;
> - QETH_CARD_TEXT_(card, 4, "b2dqw%03x", event);
> + QETH_CARD_TEXT_(card, 4, "b2dqw%03lx", event);
> rc = qeth_l2_br2dev_queue_work(brdev, lowerdev,
> dstdev, event,
> fdb_info->addr);
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-10-25 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 9:56 [PATCH net-next 0/9] s390/qeth: updates 2021-10-25 Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 1/9] s390/qeth: improve trace entries for MAC address (un)registration Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 2/9] s390/qeth: remove .do_ioctl() callback from driver discipline Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 3/9] s390/qeth: move qdio's QAOB cache into qeth Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 4/9] s390/qeth: clarify remaining dev_kfree_skb_any() users Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 5/9] s390/qeth: don't keep track of Input Queue count Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 6/9] s390/qeth: fix various format strings Julian Wiedmann
2021-10-25 13:22 ` Vladimir Oltean [this message]
2021-10-25 13:35 ` Julian Wiedmann
2021-10-25 14:32 ` Vladimir Oltean
2021-10-25 9:56 ` [PATCH net-next 7/9] s390/qeth: add __printf format attribute to qeth_dbf_longtext Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 8/9] s390/qeth: fix kernel doc comments Julian Wiedmann
2021-10-25 9:56 ` [PATCH net-next 9/9] s390/qeth: update kerneldoc for qeth_add_hw_header() Julian Wiedmann
2021-10-25 13:00 ` [PATCH net-next 0/9] s390/qeth: updates 2021-10-25 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211025132229.4opytunnnqnhxzdf@skbuf \
--to=olteanv@gmail.com \
--cc=davem@davemloft.net \
--cc=hca@linux.ibm.com \
--cc=jwi@linux.ibm.com \
--cc=kgraul@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox